refactor(credential): Switch to an Other constructor

Author: epage

credential/cargo-credential/src/error.rs

@@ -38,6 +38,12 @@ pub enum Error {
     Unknown,
 }
 
+impl Error {
+    pub(crate) fn other(inner: BoxError) -> Self {
+        Self::Other(inner)
+    }
+}
+
 impl StdError for Error {
     fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
         match self {
@@ -86,7 +92,7 @@ impl From<anyhow::Error> for Error {
 
 impl<T: StdError + Send + Sync + 'static> From<Box<T>> for Error {
     fn from(value: Box<T>) -> Self {
-        Error::Other(value)
+        Error::other(value)
     }
 }
 

credential/cargo-credential/src/lib.rs

@@ -226,7 +226,7 @@ pub trait Credential {
 
 /// Runs the credential interaction
 pub fn main(credential: impl Credential) {
-    let result = doit(credential).map_err(|e| Error::Other(e));
+    let result = doit(credential).map_err(|e| Error::other(e));
     if result.is_err() {
         serde_json::to_writer(std::io::stdout(), &result)
             .expect("failed to serialize credential provider error");