refactor(credential): Consolidate Other construction

Author: epage

credential/cargo-credential/src/error.rs

@@ -80,14 +80,7 @@ impl From<&str> for Error {
 
 impl From<anyhow::Error> for Error {
     fn from(value: anyhow::Error) -> Self {
-        let mut prev = None;
-        for e in value.chain().rev() {
-            prev = Some(Box::new(StringTypedError {
-                message: e.to_string(),
-                source: prev,
-            }));
-        }
-        Error::Other(prev.unwrap())
+        Error::from(Box::new(StringTypedError::from(value)))
     }
 }
 
@@ -116,6 +109,19 @@ impl std::fmt::Display for StringTypedError {
     }
 }
 
+impl From<anyhow::Error> for StringTypedError {
+    fn from(value: anyhow::Error) -> Self {
+        let mut prev = None;
+        for e in value.chain().rev() {
+            prev = Some(StringTypedError {
+                message: e.to_string(),
+                source: prev.map(Box::new),
+            });
+        }
+        prev.unwrap()
+    }
+}
+
 /// Serializer / deserializer for any boxed error.
 /// The string representation of the error, and its `source` chain can roundtrip across
 /// the serialization. The actual types are lost (downcast will not work).