Skip to content

Commit 3c673cb

Browse files
committed
Refactoring to loop over the key/values instead of hard-coding
1 parent 5e15286 commit 3c673cb

File tree

1 file changed

+6
-18
lines changed

1 file changed

+6
-18
lines changed

src/cargo/util/config/mod.rs

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1004,25 +1004,13 @@ impl Config {
10041004
}
10051005
}
10061006

1007-
if let CV::Table(mut map, _) = value {
1008-
if map.contains_key("registry") {
1009-
if let Some(mut new_map) = self.values_mut()?.remove("registry") {
1010-
let token = map.remove("registry").unwrap();
1011-
new_map.merge(token, true)?;
1012-
self.values_mut()?.insert("registry".into(), new_map);
1007+
if let CV::Table(map, _) = value {
1008+
for (k, v) in map {
1009+
if let Some(mut base_map) = self.values_mut()?.remove(&k) {
1010+
base_map.merge(v, true)?;
1011+
self.values_mut()?.insert(k.into(), base_map);
10131012
} else {
1014-
self.values_mut()?
1015-
.insert("registry".into(), map.remove("registry").unwrap());
1016-
}
1017-
}
1018-
if map.contains_key("registries") {
1019-
if let Some(mut new_map) = self.values_mut()?.remove("registries") {
1020-
let token = map.remove("registries").unwrap();
1021-
new_map.merge(token, true)?;
1022-
self.values_mut()?.insert("registries".into(), new_map);
1023-
} else {
1024-
self.values_mut()?
1025-
.insert("registries".into(), map.remove("registries").unwrap());
1013+
self.values_mut()?.insert(k.into(), v);
10261014
}
10271015
}
10281016
}

0 commit comments

Comments
 (0)