Skip to content

Commit 34cba46

Browse files
committed
Auto merge of #10930 - ehuss:enable-windows-tests, r=weihanglo
Enable two windows tests These two tests were disabled on Windows a long time ago. AFAICT, the reasons are no longer relevant, and it should be safe to enable these tests. See each commit for a more detailed exposition.
2 parents 1ac43cf + c0be32b commit 34cba46

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

tests/testsuite/concurrent.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -351,9 +351,7 @@ fn same_project() {
351351

352352
// Make sure that if Cargo dies while holding a lock that it's released and the
353353
// next Cargo to come in will take over cleanly.
354-
// older win versions don't support job objects, so skip test there
355354
#[cargo_test]
356-
#[cfg_attr(target_os = "windows", ignore)]
357355
fn killing_cargo_releases_the_lock() {
358356
let p = project()
359357
.file(

tests/testsuite/version.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ fn simple() {
1616
}
1717

1818
#[cargo_test]
19-
#[cfg_attr(target_os = "windows", ignore)]
2019
fn version_works_without_rustc() {
2120
let p = project().build();
2221
p.cargo("version").env("PATH", "").run();

0 commit comments

Comments
 (0)