Auto merge of #8515 - Spanfile:target-triple-opt-help-fix, r=ehuss

bors · bors · commit 25bc0df13b05 · 2020-07-23T05:17:25.000Z
Fix the help display for the target-triple option

The `--target` option (in `cargo build` for example) had its value name and help text flipped, so it looked like;
```
--target &lt;Build for the target triple&gt;...    TRIPLE
```
This PR swaps the `value_name` and `help` arguments for the `multi_opt` call in `command_prelude.rs`/`fn arg_target_triple()` so the value name and help text are displayed correctly.
diff --git a/src/cargo/util/command_prelude.rs b/src/cargo/util/command_prelude.rs
@@ -139,7 +139,7 @@ pub trait AppExt: Sized {
     }
 
     fn arg_target_triple(self, target: &'static str) -> Self {
-        self._arg(multi_opt("target", target, "TRIPLE"))
+        self._arg(multi_opt("target", "TRIPLE", target))
     }
 
     fn arg_target_dir(self) -> Self {

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ pub trait AppExt: Sized {`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`fn arg_target_triple(self, target: &'static str) -> Self {`
`142`		`- self._arg(multi_opt("target", target, "TRIPLE"))`
	`142`	`+ self._arg(multi_opt("target", "TRIPLE", target))`
`143`	`143`	`}`
`144`	`144`
`145`	`145`	`fn arg_target_dir(self) -> Self {`