Skip to content

Commit 242d7df

Browse files
committed
fix(pkgid): pkgid urls must have a host
1 parent bf5a5d5 commit 242d7df

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/cargo/core/package_id_spec.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,9 @@ impl PackageIdSpec {
9797

9898
/// Tries to convert a valid `Url` to a `PackageIdSpec`.
9999
fn from_url(mut url: Url) -> CargoResult<PackageIdSpec> {
100+
if url.host().is_none() {
101+
bail!("pkgid urls must have a host: {}", url)
102+
}
100103
if url.query().is_some() {
101104
bail!("cannot have a query string in a pkgid: {}", url)
102105
}
@@ -405,6 +408,8 @@ mod tests {
405408
assert!(PackageIdSpec::parse("baz:1.0").is_err());
406409
assert!(PackageIdSpec::parse("https://baz:1.0").is_err());
407410
assert!(PackageIdSpec::parse("https://#baz:1.0").is_err());
411+
assert!(PackageIdSpec::parse("file:///baz").is_err());
412+
assert!(PackageIdSpec::parse("/baz").is_err());
408413
}
409414

410415
#[test]

0 commit comments

Comments
 (0)