Skip to content

Commit 028d5b9

Browse files
committed
Remove rustc threads concurrency info from timings
Given `-Zjobserver-token-request` in rustc is never landed, This is never correct either.
1 parent 65cab34 commit 028d5b9

File tree

2 files changed

+2
-24
lines changed

2 files changed

+2
-24
lines changed

src/cargo/core/compiler/job_queue/mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -970,7 +970,6 @@ impl<'cfg> DrainState<'cfg> {
970970
self.active.len(),
971971
self.pending_queue.len(),
972972
self.queue.len(),
973-
self.rustc_tokens.len(),
974973
);
975974
self.timings.record_cpu();
976975

src/cargo/core/compiler/timings.rs

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,6 @@ struct Concurrency {
9292
/// Number of units that are not yet ready, because they are waiting for
9393
/// dependencies to finish.
9494
inactive: usize,
95-
/// Number of rustc "extra" threads -- i.e., how many tokens have been
96-
/// provided across all current rustc instances that are not the main thread
97-
/// tokens.
98-
rustc_parallelism: usize,
9995
}
10096

10197
impl<'cfg> Timings<'cfg> {
@@ -240,13 +236,7 @@ impl<'cfg> Timings<'cfg> {
240236
}
241237

242238
/// This is called periodically to mark the concurrency of internal structures.
243-
pub fn mark_concurrency(
244-
&mut self,
245-
active: usize,
246-
waiting: usize,
247-
inactive: usize,
248-
rustc_parallelism: usize,
249-
) {
239+
pub fn mark_concurrency(&mut self, active: usize, waiting: usize, inactive: usize) {
250240
if !self.enabled {
251241
return;
252242
}
@@ -255,7 +245,6 @@ impl<'cfg> Timings<'cfg> {
255245
active,
256246
waiting,
257247
inactive,
258-
rustc_parallelism,
259248
};
260249
self.concurrency.push(c);
261250
}
@@ -307,7 +296,7 @@ impl<'cfg> Timings<'cfg> {
307296
if !self.enabled {
308297
return Ok(());
309298
}
310-
self.mark_concurrency(0, 0, 0, 0);
299+
self.mark_concurrency(0, 0, 0);
311300
self.unit_times
312301
.sort_unstable_by(|a, b| a.start.partial_cmp(&b.start).unwrap());
313302
if self.report_html {
@@ -391,12 +380,6 @@ impl<'cfg> Timings<'cfg> {
391380
let num_cpus = available_parallelism()
392381
.map(|x| x.get().to_string())
393382
.unwrap_or_else(|_| "n/a".into());
394-
let max_rustc_concurrency = self
395-
.concurrency
396-
.iter()
397-
.map(|c| c.rustc_parallelism)
398-
.max()
399-
.unwrap();
400383
let rustc_info = render_rustc_info(bcx);
401384
let error_msg = match error {
402385
Some(e) => format!(
@@ -440,9 +423,6 @@ impl<'cfg> Timings<'cfg> {
440423
<tr>
441424
<td>rustc:</td><td>{}</td>
442425
</tr>
443-
<tr>
444-
<td>Max (global) rustc threads concurrency:</td><td>{}</td>
445-
</tr>
446426
{}
447427
</table>
448428
"#,
@@ -457,7 +437,6 @@ impl<'cfg> Timings<'cfg> {
457437
self.start_str,
458438
total_time,
459439
rustc_info,
460-
max_rustc_concurrency,
461440
error_msg,
462441
)?;
463442
Ok(())

0 commit comments

Comments
 (0)