test: edit pr event

Author: vohoanglong0107

src/bors/handlers/review.rs

@@ -183,7 +183,8 @@ mod tests {
     use crate::{
         github::PullRequestNumber,
         tests::mocks::{
-            default_pr_number, default_repo_name, BorsBuilder, BorsTester, Permissions, User, World,
+            default_pr_number, default_repo_name, BorsBuilder, BorsTester, Permissions,
+            PullRequestChangeEvent, User, World,
         },
     };
 
@@ -306,6 +307,118 @@ approve = ["+approved"]
             .await;
     }
 
+    #[sqlx::test]
+    async fn unapprove_on_base_edited(pool: sqlx::PgPool) {
+        let world = World::default();
+        world.default_repo().lock().set_config(
+            r#"
+[labels]
+approve = ["+approved"]
+"#,
+        );
+        BorsBuilder::new(pool)
+            .world(world)
+            .run_test(|mut tester| async {
+                tester.post_comment("@bors r+").await?;
+                assert_eq!(
+                    tester.get_comment().await?,
+                    format!(
+                        "Commit pr-{}-sha has been approved by `{}`",
+                        default_pr_number(),
+                        User::default_user().name
+                    ),
+                );
+                tester
+                    .edit_pull_request(
+                        default_pr_number(),
+                        PullRequestChangeEvent {
+                            from_base_sha: Some("main-sha".to_string()),
+                        },
+                    )
+                    .await?;
+
+                assert_eq!(
+                    tester.get_comment().await?,
+                    format!(
+                        r#":warning: The base branch changed to `pr-{}-sha`, and the 
+PR will need to be re-approved."#,
+                        default_pr_number()
+                    )
+                );
+                check_pr_unapproved(&tester, default_pr_number().into()).await;
+                Ok(tester)
+            })
+            .await;
+    }
+
+    #[sqlx::test]
+    async fn edit_pr_do_nothing_when_base_not_edited(pool: sqlx::PgPool) {
+        let world = World::default();
+        world.default_repo().lock().set_config(
+            r#"
+[labels]
+approve = ["+approved"]
+"#,
+        );
+        BorsBuilder::new(pool)
+            .world(world)
+            .run_test(|mut tester| async {
+                tester.post_comment("@bors r+").await?;
+                assert_eq!(
+                    tester.get_comment().await?,
+                    format!(
+                        "Commit pr-{}-sha has been approved by `{}`",
+                        default_pr_number(),
+                        User::default_user().name
+                    ),
+                );
+                tester
+                    .edit_pull_request(
+                        default_pr_number(),
+                        PullRequestChangeEvent {
+                            from_base_sha: None,
+                        },
+                    )
+                    .await?;
+
+                check_pr_approved_by(
+                    &tester,
+                    default_pr_number().into(),
+                    &User::default_user().name,
+                )
+                .await;
+                Ok(tester)
+            })
+            .await;
+    }
+
+    #[sqlx::test]
+    async fn edit_pr_do_nothing_when_not_approved(pool: sqlx::PgPool) {
+        let world = World::default();
+        world.default_repo().lock().set_config(
+            r#"
+[labels]
+approve = ["+approved"]
+"#,
+        );
+        BorsBuilder::new(pool)
+            .world(world)
+            .run_test(|mut tester| async {
+                tester
+                    .edit_pull_request(
+                        default_pr_number(),
+                        PullRequestChangeEvent {
+                            from_base_sha: Some("main-sha".to_string()),
+                        },
+                    )
+                    .await?;
+
+                // No comment should be posted
+                Ok(tester)
+            })
+            .await;
+    }
+
     async fn check_pr_approved_by(
         tester: &BorsTester,
         pr_number: PullRequestNumber,

src/tests/mocks/bors.rs

@@ -28,6 +28,8 @@ use crate::{
     ServerState, WebhookSecret,
 };
 
+use super::pull_request::{GitHubPullRequestEventPayload, PullRequestChangeEvent};
+
 pub struct BorsBuilder {
     world: World,
     pool: PgPool,
@@ -266,6 +268,18 @@ impl BorsTester {
         self.webhook_check_suite(check_suite.into()).await
     }
 
+    pub async fn edit_pull_request(
+        &mut self,
+        pr_number: u64,
+        changes: PullRequestChangeEvent,
+    ) -> anyhow::Result<()> {
+        self.send_webhook(
+            "pull_request",
+            GitHubPullRequestEventPayload::new(pr_number, "edited".to_string(), Some(changes)),
+        )
+        .await
+    }
+
     async fn webhook_comment(&mut self, comment: Comment) -> anyhow::Result<()> {
         self.send_webhook(
             "issue_comment",

src/tests/mocks/mod.rs

@@ -18,6 +18,7 @@ pub use bors::BorsTester;
 pub use comment::Comment;
 pub use permissions::Permissions;
 pub use pull_request::default_pr_number;
+pub use pull_request::PullRequestChangeEvent;
 pub use repository::default_repo_name;
 pub use repository::Branch;
 pub use repository::Repo;

src/tests/mocks/pull_request.rs

@@ -12,7 +12,8 @@ use wiremock::{
 
 use super::{
     comment::{Comment, GitHubComment},
-    dynamic_mock_req,
+    default_repo_name, dynamic_mock_req,
+    repository::GitHubRepository,
     user::GitHubUser,
     Repo, User,
 };
@@ -210,3 +211,51 @@ struct GitHubLabel {
     color: String,
     default: bool,
 }
+
+#[derive(Serialize)]
+pub(super) struct GitHubPullRequestEventPayload {
+    action: String,
+    pull_request: GitHubPullRequest,
+    changes: Option<GitHubPullRequestChanges>,
+    repository: GitHubRepository,
+}
+
+impl GitHubPullRequestEventPayload {
+    pub fn new(pr_number: u64, action: String, changes: Option<PullRequestChangeEvent>) -> Self {
+        GitHubPullRequestEventPayload {
+            action,
+            pull_request: GitHubPullRequest::new(pr_number),
+            changes: changes.map(Into::into),
+            repository: default_repo_name().into(),
+        }
+    }
+}
+
+#[derive(Serialize)]
+struct GitHubPullRequestChanges {
+    base: Option<GitHubPullRequestBaseChanges>,
+}
+
+#[derive(Serialize)]
+struct GitHubPullRequestBaseChanges {
+    sha: Option<PullRequestEventChangesFrom>,
+}
+
+#[derive(Serialize)]
+struct PullRequestEventChangesFrom {
+    pub from: String,
+}
+
+impl From<PullRequestChangeEvent> for GitHubPullRequestChanges {
+    fn from(value: PullRequestChangeEvent) -> Self {
+        GitHubPullRequestChanges {
+            base: value.from_base_sha.map(|sha| GitHubPullRequestBaseChanges {
+                sha: Some(PullRequestEventChangesFrom { from: sha }),
+            }),
+        }
+    }
+}
+
+pub struct PullRequestChangeEvent {
+    pub from_base_sha: Option<String>,
+}