Skip to content

Commit b1e68fd

Browse files
Revert "Try not parsing the entire map"
This reverts commit 1166cc8.
1 parent cd03f04 commit b1e68fd

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

src/symbolize/gimli/parse_running_mmaps_unix.rs

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -113,20 +113,20 @@ impl FromStr for MapsEntry {
113113
} else {
114114
return Err(parse_err);
115115
};
116-
// let _perms = if let &[r, w, x, p, ..] = perms_str.as_bytes() {
117-
// // If a system in the future adds a 5th field to the permission list,
118-
// // there's no reason to assume previous fields were invalidated.
119-
// [r, w, x, p]
120-
// } else {
121-
// return Err(parse_err);
122-
// };
123-
// let _offset = hex(offset_str)?;
124-
// let _dev = if let Some((major, minor)) = dev_str.split_once(':') {
125-
// (hex(major)?, hex(minor)?)
126-
// } else {
127-
// return Err(parse_err);
128-
// };
129-
// let _inode = hex(inode_str)?;
116+
let _perms = if let &[r, w, x, p, ..] = perms_str.as_bytes() {
117+
// If a system in the future adds a 5th field to the permission list,
118+
// there's no reason to assume previous fields were invalidated.
119+
[r, w, x, p]
120+
} else {
121+
return Err(parse_err);
122+
};
123+
let _offset = hex(offset_str)?;
124+
let _dev = if let Some((major, minor)) = dev_str.split_once(':') {
125+
(hex(major)?, hex(minor)?)
126+
} else {
127+
return Err(parse_err);
128+
};
129+
let _inode = hex(inode_str)?;
130130
let pathname = pathname_str.into();
131131

132132
Ok(MapsEntry {

0 commit comments

Comments
 (0)