Auto merge of rust-lang#140558 - lcnr:wf-emit-projection, r=<try>

wf: emit projection goal for aliases

To check that their normalization succeeds in the current environment. This eagerly detects ambiguous and diverging aliases.

r? `@compiler-errors`

Author: bors

compiler/rustc_hir_analysis/src/check/compare_impl_item.rs

@@ -393,7 +393,7 @@ fn compare_method_predicate_entailment<'tcx>(
             for obligation in obligations {
                 debug!(?obligation);
                 match obligation.predicate.kind().skip_binder() {
-                    // We need to register Projection oblgiations too, because we may end up with
+                    // We need to register Projection obligations too, because we may end up with
                     // an implied `X::Item: 'a`, which gets desugared into `X::Item = ?0`, `?0: 'a`.
                     // If we only register the region outlives obligation, this leads to an unconstrained var.
                     // See `implied_bounds_entailment_alias_var.rs` test.

compiler/rustc_hir_analysis/src/impl_wf_check/min_specialization.rs

@@ -381,8 +381,6 @@ fn check_predicates<'tcx>(
         let obligations =
             wf::obligations(infcx, tcx.param_env(impl1_def_id), impl1_def_id, 0, term, span)
                 .unwrap();
-
-        assert!(!obligations.has_infer());
         impl2_predicates
             .extend(traits::elaborate(tcx, obligations).map(|obligation| obligation.predicate))
     }

compiler/rustc_hir_typeck/src/fn_ctxt/inspect_obligations.rs

@@ -39,7 +39,15 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                 self.type_matches_expected_vid(expected_vid, data.self_ty())
             }
             ty::PredicateKind::Clause(ty::ClauseKind::Projection(data)) => {
-                self.type_matches_expected_vid(expected_vid, data.projection_term.self_ty())
+                match data.projection_term.kind(self.tcx) {
+                    ty::AliasTermKind::ProjectionTy | ty::AliasTermKind::ProjectionConst => {
+                        self.type_matches_expected_vid(expected_vid, data.projection_term.self_ty())
+                    }
+                    ty::AliasTermKind::InherentTy
+                    | ty::AliasTermKind::OpaqueTy
+                    | ty::AliasTermKind::FreeTy
+                    | ty::AliasTermKind::UnevaluatedConst => false,
+                }
             }
             ty::PredicateKind::Clause(ty::ClauseKind::ConstArgHasType(..))
             | ty::PredicateKind::Subtype(..)

compiler/rustc_trait_selection/src/traits/wf.rs

@@ -509,8 +509,6 @@ impl<'a, 'tcx> WfPredicates<'a, 'tcx> {
             let obligations = self.nominal_obligations(data.def_id, args);
             self.out.extend(obligations);
         }
-
-        data.args.visit_with(self);
     }
 
     fn add_wf_preds_for_projection_args(&mut self, args: GenericArgsRef<'tcx>) {
@@ -771,13 +769,34 @@ impl<'a, 'tcx> TypeVisitor<TyCtxt<'tcx>> for WfPredicates<'a, 'tcx> {
                 // Simple cases that are WF if their type args are WF.
             }
 
-            ty::Alias(ty::Projection | ty::Opaque | ty::Free, data) => {
-                let obligations = self.nominal_obligations(data.def_id, data.args);
-                self.out.extend(obligations);
-            }
-            ty::Alias(ty::Inherent, data) => {
-                self.add_wf_preds_for_inherent_projection(data);
-                return; // Subtree handled by compute_inherent_projection.
+            ty::Alias(kind, data) => {
+                let code = ObligationCauseCode::Misc;
+                let cause = self.cause(code);
+                let inf = self.infcx.next_ty_var(rustc_span::DUMMY_SP);
+                let projection_goal_supported =
+                    matches!(kind, ty::Projection) || self.infcx.next_trait_solver();
+                if projection_goal_supported && !data.has_escaping_bound_vars() {
+                    let obligation: traits::PredicateObligation<'tcx> =
+                        traits::Obligation::with_depth(
+                            self.tcx(),
+                            cause,
+                            self.recursion_depth,
+                            self.param_env,
+                            ty::ProjectionPredicate {
+                                projection_term: data.into(),
+                                term: inf.into(),
+                            },
+                        );
+                    self.out.push(obligation);
+                }
+
+                match kind {
+                    ty::Projection | ty::Opaque | ty::Free => {
+                        let obligations = self.nominal_obligations(data.def_id, data.args);
+                        self.out.extend(obligations);
+                    }
+                    ty::Inherent => self.add_wf_preds_for_inherent_projection(data),
+                }
             }
 
             ty::Adt(def, args) => {

tests/ui/associated-inherent-types/normalization-overflow.stderr renamed to tests/ui/associated-inherent-types/normalization-overflow.current.stderr

@@ -1,5 +1,5 @@
 error: overflow evaluating associated type `T::This`
-  --> $DIR/normalization-overflow.rs:9:17
+  --> $DIR/normalization-overflow.rs:12:17
    |
 LL |     type This = Self::This;
    |                 ^^^^^^^^^^

tests/ui/associated-inherent-types/normalization-overflow.next.stderr

@@ -0,0 +1,9 @@
+error[E0271]: type mismatch resolving `T::This normalizes-to _`
+  --> $DIR/normalization-overflow.rs:12:17
+   |
+LL |     type This = Self::This;
+   |                 ^^^^^^^^^^ types differ
+
+error: aborting due to 1 previous error
+
+For more information about this error, try `rustc --explain E0271`.

tests/ui/associated-inherent-types/normalization-overflow.rs

@@ -1,3 +1,6 @@
+//@ revisions: current next
+//@[next] compile-flags: -Znext-solver
+//@ ignore-compare-mode-next-solver (explicit revisions)
 #![feature(inherent_associated_types)]
 #![allow(incomplete_features)]
 
@@ -6,7 +9,9 @@
 struct T;
 
 impl T {
-    type This = Self::This; //~ ERROR overflow evaluating associated type `T::This`
+    type This = Self::This;
+    //[current]~^ ERROR overflow evaluating associated type `T::This`
+    //[next]~^^ ERROR type mismatch resolving `T::This normalizes-to _`
 }
 
 fn main() {}

tests/ui/auto-traits/assoc-ty.next.stderr

@@ -35,7 +35,15 @@ LL |     let _: <() as Trait>::Output = ();
    |
    = note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`
 
-error: aborting due to 4 previous errors
+error[E0271]: type mismatch resolving `<() as Trait>::Output normalizes-to _`
+  --> $DIR/assoc-ty.rs:15:12
+   |
+LL |     let _: <() as Trait>::Output = ();
+   |            ^^^^^^^^^^^^^^^^^^^^^ types differ
+   |
+   = note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`
+
+error: aborting due to 5 previous errors
 
 Some errors have detailed explanations: E0271, E0380, E0658.
 For more information about an error, try `rustc --explain E0271`.

tests/ui/auto-traits/assoc-ty.rs

@@ -16,4 +16,5 @@ fn main() {
     //[current]~^ ERROR mismatched types
     //[next]~^^ ERROR type mismatch resolving `<() as Trait>::Output normalizes-to _`
     //[next]~| ERROR type mismatch resolving `<() as Trait>::Output normalizes-to _`
+    //[next]~| ERROR type mismatch resolving `<() as Trait>::Output normalizes-to _`
 }

tests/ui/impl-trait/in-trait/alias-bounds-when-not-wf.stderr

@@ -18,11 +18,6 @@ help: this trait has no implementations, consider adding one
    |
 LL | trait Foo {}
    | ^^^^^^^^^
-note: required by a bound in `A`
-  --> $DIR/alias-bounds-when-not-wf.rs:8:11
-   |
-LL | type A<T: Foo> = T;
-   |           ^^^ required by this bound in `A`
 
 error[E0277]: the trait bound `usize: Foo` is not satisfied
   --> $DIR/alias-bounds-when-not-wf.rs:16:10