suggestion from review move no run option in run_test call

ABouttefeux · ABouttefeux · commit a6bf81bbf71d · 2021-04-05T17:59:57.000+02:00
diff --git a/src/librustdoc/doctest.rs b/src/librustdoc/doctest.rs
@@ -291,7 +291,7 @@ fn run_test(
     for debugging_option_str in &options.debugging_opts_strs {
         compiler.arg("-Z").arg(&debugging_option_str);
     }
-    if (no_run || options.no_run) && !compile_fail {
+    if no_run && !compile_fail {
         compiler.arg("--emit=metadata");
     }
     compiler.arg("--target").arg(match target {
@@ -361,7 +361,7 @@ fn run_test(
         }
     }
 
-    if no_run || options.no_run {
+    if no_run {
         return Ok(());
     }
 
@@ -852,7 +852,7 @@ impl Tester for Collector {
                     line,
                     options,
                     config.should_panic,
-                    config.no_run,
+                    config.no_run || options.no_run,
                     config.test_harness,
                     runtool,
                     runtool_args,

Original file line number	Diff line number	Diff line change
`@@ -291,7 +291,7 @@ fn run_test(`
`291`	`291`	`for debugging_option_str in &options.debugging_opts_strs {`
`292`	`292`	`compiler.arg("-Z").arg(&debugging_option_str);`
`293`	`293`	`}`
`294`		`- if (no_run \|\| options.no_run) && !compile_fail {`
	`294`	`+ if no_run && !compile_fail {`
`295`	`295`	`compiler.arg("--emit=metadata");`
`296`	`296`	`}`
`297`	`297`	`compiler.arg("--target").arg(match target {`
`@@ -361,7 +361,7 @@ fn run_test(`
`361`	`361`	`}`
`362`	`362`	`}`
`363`	`363`
`364`		`- if no_run \|\| options.no_run {`
	`364`	`+ if no_run {`
`365`	`365`	`return Ok(());`
`366`	`366`	`}`
`367`	`367`
`@@ -852,7 +852,7 @@ impl Tester for Collector {`
`852`	`852`	`line,`
`853`	`853`	`options,`
`854`	`854`	`config.should_panic,`
`855`		`- config.no_run,`
	`855`	`+ config.no_run \|\| options.no_run,`
`856`	`856`	`config.test_harness,`
`857`	`857`	`runtool,`
`858`	`858`	`runtool_args,`