Skip to content
This repository was archived by the owner on May 28, 2025. It is now read-only.

Commit 8fc9e67

Browse files
committed
[Clippy] Swap float_equality_without_abs to use diagnostic items instead of paths
1 parent 7ffd485 commit 8fc9e67

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

clippy_lints/src/operators/float_equality_without_abs.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
use clippy_utils::diagnostics::span_lint_and_then;
2-
use clippy_utils::{match_def_path, paths, sugg};
2+
use clippy_utils::sugg;
33
use rustc_ast::util::parser::AssocOp;
44
use rustc_errors::Applicability;
55
use rustc_hir::def::{DefKind, Res};
66
use rustc_hir::{BinOpKind, Expr, ExprKind};
77
use rustc_lint::LateContext;
88
use rustc_middle::ty;
9-
use rustc_span::source_map::Spanned;
9+
use rustc_span::{sym, source_map::Spanned};
1010

1111
use super::FLOAT_EQUALITY_WITHOUT_ABS;
1212

@@ -36,7 +36,7 @@ pub(crate) fn check<'tcx>(
3636
// right hand side matches either f32::EPSILON or f64::EPSILON
3737
&& let ExprKind::Path(ref epsilon_path) = rhs.kind
3838
&& let Res::Def(DefKind::AssocConst, def_id) = cx.qpath_res(epsilon_path, rhs.hir_id)
39-
&& (match_def_path(cx, def_id, &paths::F32_EPSILON) || match_def_path(cx, def_id, &paths::F64_EPSILON))
39+
&& ([sym::f32_epsilon, sym::f64_epsilon].into_iter().any(|sym| cx.tcx.is_diagnostic_item(sym, def_id)))
4040

4141
// values of the subtractions on the left hand side are of the type float
4242
&& let t_val_l = cx.typeck_results().expr_ty(val_l)

clippy_utils/src/paths.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ pub const APPLICABILITY_VALUES: [[&str; 3]; 4] = [
1414
pub const DIAG: [&str; 2] = ["rustc_errors", "Diag"];
1515
pub const EARLY_CONTEXT: [&str; 2] = ["rustc_lint", "EarlyContext"];
1616
pub const EARLY_LINT_PASS: [&str; 3] = ["rustc_lint", "passes", "EarlyLintPass"];
17-
pub const F32_EPSILON: [&str; 4] = ["core", "f32", "<impl f32>", "EPSILON"];
18-
pub const F64_EPSILON: [&str; 4] = ["core", "f64", "<impl f64>", "EPSILON"];
1917
pub const FILE_OPTIONS: [&str; 4] = ["std", "fs", "File", "options"];
2018
#[expect(clippy::invalid_paths)] // internal lints do not know about all external crates
2119
pub const FUTURES_IO_ASYNCREADEXT: [&str; 3] = ["futures_util", "io", "AsyncReadExt"];

0 commit comments

Comments
 (0)