review comments: only suggest one substitution

estebank · estebank · commit 7cde07e5cc5c · 2020-06-10T14:09:51.000-07:00
diff --git a/src/librustc_trait_selection/traits/error_reporting/mod.rs b/src/librustc_trait_selection/traits/error_reporting/mod.rs
@@ -1759,48 +1759,27 @@ pub fn recursive_type_with_infinite_size_error(
     for &span in &spans {
         err.span_label(span, "recursive without indirection");
     }
-    let short_msg = format!("insert some indirection to make `{}` representable", path);
     let msg = format!(
         "insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `{}` representable",
         path,
     );
-    match &spans[..] {
-        [span] => {
-            err.multipart_suggestions(
-                &short_msg,
-                vec![
+    if spans.len() <= 4 {
+        err.multipart_suggestion(
+            &msg,
+            spans
+                .iter()
+                .flat_map(|&span| {
                     vec![
                         (span.shrink_to_lo(), "Box<".to_string()),
                         (span.shrink_to_hi(), ">".to_string()),
-                    ],
-                    vec![
-                        (span.shrink_to_lo(), "Rc<".to_string()),
-                        (span.shrink_to_hi(), ">".to_string()),
-                    ],
-                    vec![(span.shrink_to_lo(), "&".to_string())],
-                ],
-                Applicability::HasPlaceholders,
-            );
-        }
-        _ if spans.len() <= 4 => {
-            err.multipart_suggestion(
-                &msg,
-                spans
-                    .iter()
-                    .flat_map(|&span| {
-                        vec![
-                            (span.shrink_to_lo(), "Box<".to_string()),
-                            (span.shrink_to_hi(), ">".to_string()),
-                        ]
-                        .into_iter()
-                    })
-                    .collect(),
-                Applicability::HasPlaceholders,
-            );
-        }
-        _ => {
-            err.help(&msg);
-        }
+                    ]
+                    .into_iter()
+                })
+                .collect(),
+            Applicability::HasPlaceholders,
+        );
+    } else {
+        err.help(&msg);
     }
     err.emit();
 }
diff --git a/src/test/ui/infinite/infinite-tag-type-recursion.stderr b/src/test/ui/infinite/infinite-tag-type-recursion.stderr
@@ -6,14 +6,10 @@ LL | enum MList { Cons(isize, MList), Nil }
    | |
    | recursive type has infinite size
    |
-help: insert some indirection to make `MList` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `MList` representable
    |
 LL | enum MList { Cons(isize, Box<MList>), Nil }
    |                          ^^^^     ^
-LL | enum MList { Cons(isize, Rc<MList>), Nil }
-   |                          ^^^     ^
-LL | enum MList { Cons(isize, &MList), Nil }
-   |                          ^
 
 error[E0391]: cycle detected when computing drop-check constraints for `MList`
   --> $DIR/infinite-tag-type-recursion.rs:1:1
diff --git a/src/test/ui/issues/issue-17431-1.stderr b/src/test/ui/issues/issue-17431-1.stderr
@@ -6,14 +6,10 @@ LL | struct Foo { foo: Option<Option<Foo>> }
    | |
    | recursive type has infinite size
    |
-help: insert some indirection to make `Foo` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Foo` representable
    |
 LL | struct Foo { foo: Box<Option<Option<Foo>>> }
    |                   ^^^^                   ^
-LL | struct Foo { foo: Rc<Option<Option<Foo>>> }
-   |                   ^^^                   ^
-LL | struct Foo { foo: &Option<Option<Foo>> }
-   |                   ^
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/issues/issue-17431-2.stderr b/src/test/ui/issues/issue-17431-2.stderr
@@ -6,14 +6,10 @@ LL | struct Baz { q: Option<Foo> }
    | |
    | recursive type has infinite size
    |
-help: insert some indirection to make `Baz` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Baz` representable
    |
 LL | struct Baz { q: Box<Option<Foo>> }
    |                 ^^^^           ^
-LL | struct Baz { q: Rc<Option<Foo>> }
-   |                 ^^^           ^
-LL | struct Baz { q: &Option<Foo> }
-   |                 ^
 
 error[E0072]: recursive type `Foo` has infinite size
   --> $DIR/issue-17431-2.rs:4:1
@@ -23,14 +19,10 @@ LL | struct Foo { q: Option<Baz> }
    | |
    | recursive type has infinite size
    |
-help: insert some indirection to make `Foo` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Foo` representable
    |
 LL | struct Foo { q: Box<Option<Baz>> }
    |                 ^^^^           ^
-LL | struct Foo { q: Rc<Option<Baz>> }
-   |                 ^^^           ^
-LL | struct Foo { q: &Option<Baz> }
-   |                 ^
 
 error: aborting due to 2 previous errors
 
diff --git a/src/test/ui/issues/issue-17431-3.stderr b/src/test/ui/issues/issue-17431-3.stderr
@@ -6,14 +6,10 @@ LL | struct Foo { foo: Mutex<Option<Foo>> }
    | |
    | recursive type has infinite size
    |
-help: insert some indirection to make `Foo` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Foo` representable
    |
 LL | struct Foo { foo: Box<Mutex<Option<Foo>>> }
    |                   ^^^^                  ^
-LL | struct Foo { foo: Rc<Mutex<Option<Foo>>> }
-   |                   ^^^                  ^
-LL | struct Foo { foo: &Mutex<Option<Foo>> }
-   |                   ^
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/issues/issue-17431-4.stderr b/src/test/ui/issues/issue-17431-4.stderr
@@ -6,14 +6,10 @@ LL | struct Foo<T> { foo: Option<Option<Foo<T>>>, marker: marker::PhantomData<T>
    | |
    | recursive type has infinite size
    |
-help: insert some indirection to make `Foo` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Foo` representable
    |
 LL | struct Foo<T> { foo: Box<Option<Option<Foo<T>>>>, marker: marker::PhantomData<T> }
    |                      ^^^^                      ^
-LL | struct Foo<T> { foo: Rc<Option<Option<Foo<T>>>>, marker: marker::PhantomData<T> }
-   |                      ^^^                      ^
-LL | struct Foo<T> { foo: &Option<Option<Foo<T>>>, marker: marker::PhantomData<T> }
-   |                      ^
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/issues/issue-17431-5.stderr b/src/test/ui/issues/issue-17431-5.stderr
@@ -6,14 +6,10 @@ LL | struct Bar<T> { x: Bar<Foo> , marker: marker::PhantomData<T> }
    | |
    | recursive type has infinite size
    |
-help: insert some indirection to make `Bar` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Bar` representable
    |
 LL | struct Bar<T> { x: Box<Bar<Foo>> , marker: marker::PhantomData<T> }
    |                    ^^^^        ^
-LL | struct Bar<T> { x: Rc<Bar<Foo>> , marker: marker::PhantomData<T> }
-   |                    ^^^        ^
-LL | struct Bar<T> { x: &Bar<Foo> , marker: marker::PhantomData<T> }
-   |                    ^
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/issues/issue-17431-6.stderr b/src/test/ui/issues/issue-17431-6.stderr
@@ -6,14 +6,10 @@ LL | enum Foo { X(Mutex<Option<Foo>>) }
    | |
    | recursive type has infinite size
    |
-help: insert some indirection to make `Foo` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Foo` representable
    |
 LL | enum Foo { X(Box<Mutex<Option<Foo>>>) }
    |              ^^^^                  ^
-LL | enum Foo { X(Rc<Mutex<Option<Foo>>>) }
-   |              ^^^                  ^
-LL | enum Foo { X(&Mutex<Option<Foo>>) }
-   |              ^
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/issues/issue-17431-7.stderr b/src/test/ui/issues/issue-17431-7.stderr
@@ -6,14 +6,10 @@ LL | enum Foo { Voo(Option<Option<Foo>>) }
    | |
    | recursive type has infinite size
    |
-help: insert some indirection to make `Foo` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Foo` representable
    |
 LL | enum Foo { Voo(Box<Option<Option<Foo>>>) }
    |                ^^^^                   ^
-LL | enum Foo { Voo(Rc<Option<Option<Foo>>>) }
-   |                ^^^                   ^
-LL | enum Foo { Voo(&Option<Option<Foo>>) }
-   |                ^
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/issues/issue-2718-a.stderr b/src/test/ui/issues/issue-2718-a.stderr
@@ -7,14 +7,10 @@ LL |     pub struct Pong(SendPacket<Ping>);
    |     |               recursive without indirection
    |     recursive type has infinite size
    |
-help: insert some indirection to make `pingpong::Pong` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `pingpong::Pong` representable
    |
 LL |     pub struct Pong(Box<SendPacket<Ping>>);
    |                     ^^^^                ^
-LL |     pub struct Pong(Rc<SendPacket<Ping>>);
-   |                     ^^^                ^
-LL |     pub struct Pong(&SendPacket<Ping>);
-   |                     ^
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/issues/issue-3008-1.stderr b/src/test/ui/issues/issue-3008-1.stderr
@@ -7,14 +7,10 @@ LL | enum Bar {
 LL |     BarSome(Bar)
    |             --- recursive without indirection
    |
-help: insert some indirection to make `Bar` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Bar` representable
    |
 LL |     BarSome(Box<Bar>)
    |             ^^^^   ^
-LL |     BarSome(Rc<Bar>)
-   |             ^^^   ^
-LL |     BarSome(&Bar)
-   |             ^
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/issues/issue-3008-2.stderr b/src/test/ui/issues/issue-3008-2.stderr
@@ -6,14 +6,10 @@ LL | struct Bar { x: Bar }
    | |
    | recursive type has infinite size
    |
-help: insert some indirection to make `Bar` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Bar` representable
    |
 LL | struct Bar { x: Box<Bar> }
    |                 ^^^^   ^
-LL | struct Bar { x: Rc<Bar> }
-   |                 ^^^   ^
-LL | struct Bar { x: &Bar }
-   |                 ^
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/issues/issue-3008-3.stderr b/src/test/ui/issues/issue-3008-3.stderr
@@ -6,14 +6,10 @@ LL | enum E2<T> { V2(E2<E1>, marker::PhantomData<T>), }
    | |
    | recursive type has infinite size
    |
-help: insert some indirection to make `E2` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `E2` representable
    |
 LL | enum E2<T> { V2(Box<E2<E1>>, marker::PhantomData<T>), }
    |                 ^^^^      ^
-LL | enum E2<T> { V2(Rc<E2<E1>>, marker::PhantomData<T>), }
-   |                 ^^^      ^
-LL | enum E2<T> { V2(&E2<E1>, marker::PhantomData<T>), }
-   |                 ^
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/issues/issue-3779.stderr b/src/test/ui/issues/issue-3779.stderr
@@ -7,14 +7,10 @@ LL |
 LL |     element: Option<S>
    |              --------- recursive without indirection
    |
-help: insert some indirection to make `S` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `S` representable
    |
 LL |     element: Box<Option<S>>
    |              ^^^^         ^
-LL |     element: Rc<Option<S>>
-   |              ^^^         ^
-LL |     element: &Option<S>
-   |              ^
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/issues/issue-57271.stderr b/src/test/ui/issues/issue-57271.stderr
@@ -7,14 +7,10 @@ LL |     Class(ClassTypeSignature),
 LL |     Array(TypeSignature),
    |           ------------- recursive without indirection
    |
-help: insert some indirection to make `ObjectType` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `ObjectType` representable
    |
 LL |     Array(Box<TypeSignature>),
    |           ^^^^             ^
-LL |     Array(Rc<TypeSignature>),
-   |           ^^^             ^
-LL |     Array(&TypeSignature),
-   |           ^
 
 error[E0072]: recursive type `TypeSignature` has infinite size
   --> $DIR/issue-57271.rs:19:1
@@ -25,14 +21,10 @@ LL |     Base(BaseType),
 LL |     Object(ObjectType),
    |            ---------- recursive without indirection
    |
-help: insert some indirection to make `TypeSignature` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `TypeSignature` representable
    |
 LL |     Object(Box<ObjectType>),
    |            ^^^^          ^
-LL |     Object(Rc<ObjectType>),
-   |            ^^^          ^
-LL |     Object(&ObjectType),
-   |            ^
 
 error: aborting due to 2 previous errors
 
diff --git a/src/test/ui/recursion/recursive-enum.stderr b/src/test/ui/recursion/recursive-enum.stderr
@@ -6,14 +6,10 @@ LL | enum List<T> { Cons(T, List<T>), Nil }
    | |
    | recursive type has infinite size
    |
-help: insert some indirection to make `List` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `List` representable
    |
 LL | enum List<T> { Cons(T, Box<List<T>>), Nil }
    |                        ^^^^       ^
-LL | enum List<T> { Cons(T, Rc<List<T>>), Nil }
-   |                        ^^^       ^
-LL | enum List<T> { Cons(T, &List<T>), Nil }
-   |                        ^
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/sized-cycle-note.stderr b/src/test/ui/sized-cycle-note.stderr
@@ -6,14 +6,10 @@ LL | struct Baz { q: Option<Foo> }
    | |
    | recursive type has infinite size
    |
-help: insert some indirection to make `Baz` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Baz` representable
    |
 LL | struct Baz { q: Box<Option<Foo>> }
    |                 ^^^^           ^
-LL | struct Baz { q: Rc<Option<Foo>> }
-   |                 ^^^           ^
-LL | struct Baz { q: &Option<Foo> }
-   |                 ^
 
 error[E0072]: recursive type `Foo` has infinite size
   --> $DIR/sized-cycle-note.rs:11:1
@@ -23,14 +19,10 @@ LL | struct Foo { q: Option<Baz> }
    | |
    | recursive type has infinite size
    |
-help: insert some indirection to make `Foo` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Foo` representable
    |
 LL | struct Foo { q: Box<Option<Baz>> }
    |                 ^^^^           ^
-LL | struct Foo { q: Rc<Option<Baz>> }
-   |                 ^^^           ^
-LL | struct Foo { q: &Option<Baz> }
-   |                 ^
 
 error: aborting due to 2 previous errors
 
diff --git a/src/test/ui/span/E0072.stderr b/src/test/ui/span/E0072.stderr
@@ -7,14 +7,10 @@ LL |     head: u8,
 LL |     tail: Option<ListNode>,
    |           ---------------- recursive without indirection
    |
-help: insert some indirection to make `ListNode` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `ListNode` representable
    |
 LL |     tail: Box<Option<ListNode>>,
    |           ^^^^                ^
-LL |     tail: Rc<Option<ListNode>>,
-   |           ^^^                ^
-LL |     tail: &Option<ListNode>,
-   |           ^
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/span/multiline-span-E0072.stderr b/src/test/ui/span/multiline-span-E0072.stderr
@@ -10,14 +10,10 @@ LL | |     tail: Option<ListNode>,
 LL | | }
    | |_^ recursive type has infinite size
    |
-help: insert some indirection to make `ListNode` representable
+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `ListNode` representable
    |
 LL |     tail: Box<Option<ListNode>>,
    |           ^^^^                ^
-LL |     tail: Rc<Option<ListNode>>,
-   |           ^^^                ^
-LL |     tail: &Option<ListNode>,
-   |           ^
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/span/recursive-type-field.stderr b/src/test/ui/span/recursive-type-field.stderr
diff --git a/src/test/ui/type/type-recursive.stderr b/src/test/ui/type/type-recursive.stderr
diff --git a/src/test/ui/union/union-nonrepresentable.stderr b/src/test/ui/union/union-nonrepresentable.stderr

Original file line number	Diff line number	Diff line change
`@@ -6,14 +6,10 @@ LL \| struct Foo { foo: Option<Option<Foo>> }`
`6`	`6`	`\| \|`
`7`	`7`	`\| recursive type has infinite size`
`8`	`8`	`\|`
`9`		-help: insert some indirection to make `Foo` representable
	`9`	+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Foo` representable
`10`	`10`	`\|`
`11`	`11`	`LL \| struct Foo { foo: Box<Option<Option<Foo>>> }`
`12`	`12`	`\| ^^^^ ^`
`13`		`-LL \| struct Foo { foo: Rc<Option<Option<Foo>>> }`
`14`		`- \| ^^^ ^`
`15`		`-LL \| struct Foo { foo: &Option<Option<Foo>> }`
`16`		`- \| ^`
`17`	`13`
`18`	`14`	`error: aborting due to previous error`
`19`	`15`
Original file line number	Diff line number	Diff line change
`@@ -6,14 +6,10 @@ LL \| struct Foo<T> { foo: Option<Option<Foo<T>>>, marker: marker::PhantomData<T>`
`6`	`6`	`\| \|`
`7`	`7`	`\| recursive type has infinite size`
`8`	`8`	`\|`
`9`		-help: insert some indirection to make `Foo` representable
	`9`	+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Foo` representable
`10`	`10`	`\|`
`11`	`11`	`LL \| struct Foo<T> { foo: Box<Option<Option<Foo<T>>>>, marker: marker::PhantomData<T> }`
`12`	`12`	`\| ^^^^ ^`
`13`		`-LL \| struct Foo<T> { foo: Rc<Option<Option<Foo<T>>>>, marker: marker::PhantomData<T> }`
`14`		`- \| ^^^ ^`
`15`		`-LL \| struct Foo<T> { foo: &Option<Option<Foo<T>>>, marker: marker::PhantomData<T> }`
`16`		`- \| ^`
`17`	`13`
`18`	`14`	`error: aborting due to previous error`
`19`	`15`
Original file line number	Diff line number	Diff line change
`@@ -6,14 +6,10 @@ LL \| struct Bar<T> { x: Bar<Foo> , marker: marker::PhantomData<T> }`
`6`	`6`	`\| \|`
`7`	`7`	`\| recursive type has infinite size`
`8`	`8`	`\|`
`9`		-help: insert some indirection to make `Bar` representable
	`9`	+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Bar` representable
`10`	`10`	`\|`
`11`	`11`	`LL \| struct Bar<T> { x: Box<Bar<Foo>> , marker: marker::PhantomData<T> }`
`12`	`12`	`\| ^^^^ ^`
`13`		`-LL \| struct Bar<T> { x: Rc<Bar<Foo>> , marker: marker::PhantomData<T> }`
`14`		`- \| ^^^ ^`
`15`		`-LL \| struct Bar<T> { x: &Bar<Foo> , marker: marker::PhantomData<T> }`
`16`		`- \| ^`
`17`	`13`
`18`	`14`	`error: aborting due to previous error`
`19`	`15`
Original file line number	Diff line number	Diff line change
`@@ -6,14 +6,10 @@ LL \| enum Foo { X(Mutex<Option<Foo>>) }`
`6`	`6`	`\| \|`
`7`	`7`	`\| recursive type has infinite size`
`8`	`8`	`\|`
`9`		-help: insert some indirection to make `Foo` representable
	`9`	+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Foo` representable
`10`	`10`	`\|`
`11`	`11`	`LL \| enum Foo { X(Box<Mutex<Option<Foo>>>) }`
`12`	`12`	`\| ^^^^ ^`
`13`		`-LL \| enum Foo { X(Rc<Mutex<Option<Foo>>>) }`
`14`		`- \| ^^^ ^`
`15`		`-LL \| enum Foo { X(&Mutex<Option<Foo>>) }`
`16`		`- \| ^`
`17`	`13`
`18`	`14`	`error: aborting due to previous error`
`19`	`15`
Original file line number	Diff line number	Diff line change
`@@ -6,14 +6,10 @@ LL \| enum Foo { Voo(Option<Option<Foo>>) }`
`6`	`6`	`\| \|`
`7`	`7`	`\| recursive type has infinite size`
`8`	`8`	`\|`
`9`		-help: insert some indirection to make `Foo` representable
	`9`	+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `Foo` representable
`10`	`10`	`\|`
`11`	`11`	`LL \| enum Foo { Voo(Box<Option<Option<Foo>>>) }`
`12`	`12`	`\| ^^^^ ^`
`13`		`-LL \| enum Foo { Voo(Rc<Option<Option<Foo>>>) }`
`14`		`- \| ^^^ ^`
`15`		`-LL \| enum Foo { Voo(&Option<Option<Foo>>) }`
`16`		`- \| ^`
`17`	`13`
`18`	`14`	`error: aborting due to previous error`
`19`	`15`
Original file line number	Diff line number	Diff line change
`@@ -7,14 +7,10 @@ LL \| pub struct Pong(SendPacket<Ping>);`
`7`	`7`	`\| \| recursive without indirection`
`8`	`8`	`\| recursive type has infinite size`
`9`	`9`	`\|`
`10`		-help: insert some indirection to make `pingpong::Pong` representable
	`10`	+help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `pingpong::Pong` representable
`11`	`11`	`\|`
`12`	`12`	`LL \| pub struct Pong(Box<SendPacket<Ping>>);`
`13`	`13`	`\| ^^^^ ^`
`14`		`-LL \| pub struct Pong(Rc<SendPacket<Ping>>);`
`15`		`- \| ^^^ ^`
`16`		`-LL \| pub struct Pong(&SendPacket<Ping>);`
`17`		`- \| ^`
`18`	`14`
`19`	`15`	`error: aborting due to previous error`
`20`	`16`