Skip to content

Commit cb66dd8

Browse files
tspiterijswrenn
andauthored
Apply suggestions from code review
Co-Authored-By: Jack Wrenn <johnswrenn@gmail.com>
1 parent 8a5fe0b commit cb66dd8

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/lib.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2514,7 +2514,7 @@ pub trait Itertools : Iterator {
25142514
where Self: Sized, K: PartialOrd, F: FnMut(&Self::Item) -> K
25152515
{
25162516
use MinMaxResult::{NoElements, OneElement, MinMax};
2517-
match minmax::minmax_impl(self.enumerate(), |x| key(&x.1), |_, _, xk, yk| xk < yk) {
2517+
match self.enumerate().minmax_by_key(|e| key(&e.1)) {
25182518
NoElements => NoElements,
25192519
OneElement(x) => OneElement(x.0),
25202520
MinMax(x, y) => MinMax(x.0, y.0),
@@ -2557,11 +2557,7 @@ pub trait Itertools : Iterator {
25572557
where Self: Sized, F: FnMut(&Self::Item, &Self::Item) -> Ordering
25582558
{
25592559
use MinMaxResult::{NoElements, OneElement, MinMax};
2560-
match minmax::minmax_impl(
2561-
self.enumerate(),
2562-
|_| (),
2563-
|x, y, _, _| Ordering::Less == compare(&x.1, &y.1)
2564-
) {
2560+
match self.enumerate().minmax_by(|x, y| compare(&x.1, &y.1)) {
25652561
NoElements => NoElements,
25662562
OneElement(x) => OneElement(x.0),
25672563
MinMax(x, y) => MinMax(x.0, y.0),

0 commit comments

Comments
 (0)