Merge pull request #772 from duskmoon314/accessor_ref

burrbull · web-flow · commit 10edb19dae40 · 2023-11-27T06:33:28.000Z
Remove ref in ArrayElemAccessor to solve the `needless_borrow` warning
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 
 ## [Unreleased]
 
+- Remove needless reference in `ArrayElemAccessor`
+
 ## [v0.31.0] - 2023-11-24
 
 - Use methods to access any register or cluster
diff --git a/src/generate/peripheral/accessor.rs b/src/generate/peripheral/accessor.rs
@@ -204,7 +204,7 @@ impl ToTokens for ArrayElemAccessor {
             #[doc = #doc]
             #[inline(always)]
             pub const fn #name(&self) -> &#ty {
-                &self.#basename(#i)
+                self.#basename(#i)
             }
         }
         .to_tokens(tokens);

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ impl ToTokens for ArrayElemAccessor {`
`204`	`204`	`#[doc = #doc]`
`205`	`205`	`#[inline(always)]`
`206`	`206`	`pub const fn #name(&self) -> &#ty {`
`207`		`- &self.#basename(#i)`
	`207`	`+ self.#basename(#i)`
`208`	`208`	`}`
`209`	`209`	`}`
`210`	`210`	`.to_tokens(tokens);`