Skip to content

Commit 149dfa5

Browse files
authored
Merge pull request #58 from pheki/fix-warnings
Run rustfmt and fix warnings
2 parents 043c0f3 + a427d09 commit 149dfa5

File tree

7 files changed

+156
-132
lines changed

7 files changed

+156
-132
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,6 @@ Cargo.lock
1414

1515
# Intellij IDEA
1616
.idea
17+
18+
# macOS DS_Store files
19+
.DS_Store

examples/blinky.rs

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88

99
extern crate sysfs_gpio;
1010

11-
use sysfs_gpio::{Direction, Pin};
12-
use std::time::Duration;
13-
use std::thread::sleep;
1411
use std::env;
12+
use std::thread::sleep;
13+
use std::time::Duration;
14+
use sysfs_gpio::{Direction, Pin};
1515

1616
struct Arguments {
1717
pin: u64,
@@ -58,20 +58,18 @@ fn get_args() -> Option<Arguments> {
5858
Err(_) => return None,
5959
};
6060
Some(Arguments {
61-
pin: pin,
62-
duration_ms: duration_ms,
63-
period_ms: period_ms,
64-
})
61+
pin: pin,
62+
duration_ms: duration_ms,
63+
period_ms: period_ms,
64+
})
6565
}
6666

6767
fn main() {
6868
match get_args() {
6969
None => print_usage(),
70-
Some(args) => {
71-
match blink_my_led(args.pin, args.duration_ms, args.period_ms) {
72-
Ok(()) => println!("Success!"),
73-
Err(err) => println!("We have a blinking problem: {}", err),
74-
}
75-
}
70+
Some(args) => match blink_my_led(args.pin, args.duration_ms, args.period_ms) {
71+
Ok(()) => println!("Success!"),
72+
Err(err) => println!("We have a blinking problem: {}", err),
73+
},
7674
}
7775
}

examples/interrupt.rs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88

99
extern crate sysfs_gpio;
1010

11-
use sysfs_gpio::{Direction, Edge, Pin};
1211
use std::env;
1312
use std::io::prelude::*;
1413
use std::io::stdout;
14+
use sysfs_gpio::{Direction, Edge, Pin};
1515

1616
fn interrupt(pin: u64) -> sysfs_gpio::Result<()> {
1717
let input = Pin::new(pin);
@@ -38,12 +38,10 @@ fn main() {
3838
println!("Usage: ./interrupt <pin>");
3939
} else {
4040
match args[1].parse::<u64>() {
41-
Ok(pin) => {
42-
match interrupt(pin) {
43-
Ok(()) => println!("Interrupting Complete!"),
44-
Err(err) => println!("Error: {}", err),
45-
}
46-
}
41+
Ok(pin) => match interrupt(pin) {
42+
Ok(()) => println!("Interrupting Complete!"),
43+
Err(err) => println!("Error: {}", err),
44+
},
4745
Err(_) => println!("Usage: ./interrupt <pin>"),
4846
}
4947
}

examples/poll.rs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88

99
extern crate sysfs_gpio;
1010

11-
use sysfs_gpio::{Direction, Pin};
1211
use std::env;
1312
use std::thread::sleep;
1413
use std::time::Duration;
14+
use sysfs_gpio::{Direction, Pin};
1515

1616
fn poll(pin_num: u64) -> sysfs_gpio::Result<()> {
1717
// NOTE: this currently runs forever and as such if
@@ -40,12 +40,10 @@ fn main() {
4040
println!("Usage: ./poll <pin>");
4141
} else {
4242
match args[1].parse::<u64>() {
43-
Ok(pin) => {
44-
match poll(pin) {
45-
Ok(()) => println!("Polling Complete!"),
46-
Err(err) => println!("Error: {}", err),
47-
}
48-
}
43+
Ok(pin) => match poll(pin) {
44+
Ok(()) => println!("Polling Complete!"),
45+
Err(err) => println!("Error: {}", err),
46+
},
4947
Err(_) => println!("Usage: ./poll <pin>"),
5048
}
5149
}

examples/tokio.rs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ extern crate tokio;
99
use std::env;
1010

1111
#[cfg(feature = "use_tokio")]
12-
use futures::{Future, lazy, Stream};
12+
use futures::{lazy, Future, Stream};
1313

1414
#[cfg(feature = "use_tokio")]
1515
use sysfs_gpio::{Direction, Edge, Pin};
@@ -27,12 +27,15 @@ fn stream(pin_nums: Vec<u64>) -> sysfs_gpio::Result<()> {
2727
pin.export().unwrap();
2828
pin.set_direction(Direction::In).unwrap();
2929
pin.set_edge(Edge::BothEdges).unwrap();
30-
tokio::spawn(pin.get_value_stream().unwrap()
31-
.for_each(move |val| {
32-
println!("Pin {} changed value to {}", i, val);
33-
Ok(())
34-
})
35-
.map_err(|_| ()));
30+
tokio::spawn(
31+
pin.get_value_stream()
32+
.unwrap()
33+
.for_each(move |val| {
34+
println!("Pin {} changed value to {}", i, val);
35+
Ok(())
36+
})
37+
.map_err(|_| ()),
38+
);
3639
}
3740
Ok(())
3841
});

src/error.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1+
use nix;
12
use std::convert;
23
use std::fmt;
34
use std::io;
4-
use nix;
55

66
#[derive(Debug)]
77
pub enum Error {
@@ -25,7 +25,7 @@ impl ::std::error::Error for Error {
2525
}
2626
}
2727

28-
fn cause(&self) -> Option<&::std::error::Error> {
28+
fn cause(&self) -> Option<&dyn std::error::Error> {
2929
match *self {
3030
Error::Io(ref e) => Some(e),
3131
_ => None,
@@ -44,7 +44,6 @@ impl fmt::Display for Error {
4444
}
4545
}
4646

47-
4847
impl convert::From<io::Error> for Error {
4948
fn from(e: io::Error) -> Error {
5049
Error::Io(e)

0 commit comments

Comments
 (0)