Address all issues brought up by clippy

Nothing serious but there were a few extra clones and the like that
are not needed.

Signed-off-by: Paul Osborne <osbpau@gmail.com>

Author: posborne

src/config.rs

@@ -17,7 +17,7 @@ use std::str::FromStr;
 use sysfs_gpio;
 use toml;
 
-const DEFAULT_SYMLINK_ROOT: &'static str = "/var/run/gpio";
+const DEFAULT_SYMLINK_ROOT: &str = "/var/run/gpio";
 
 #[derive(Debug, PartialEq, Clone)]
 pub struct Direction(pub sysfs_gpio::Direction);
@@ -118,7 +118,7 @@ impl FromStr for GpioConfig {
         match cfg {
             Ok(cfg) => {
                 let val_config: GpioConfig = toml::from_str(&config).unwrap();
-                (val_config.validate().or_else(|e| Err(Error::from(e))))?;
+                val_config.validate()?;
                 Ok(cfg)
             }
             Err(e) => Err(Error::ParserErrors(e)),
@@ -244,7 +244,7 @@ impl GpioConfig {
             let existing = match self.pins.iter_mut().find(|p| p.num == other_pin.num) {
                 Some(pin) => {
                     pin.names.extend(other_pin.names.clone());
-                    pin.direction = other_pin.direction.clone(); // TODO impl copy
+                    pin.direction = other_pin.direction;
                     pin.export = other_pin.export;
                     pin.active_low = other_pin.active_low;
                     true

src/export.rs

@@ -128,12 +128,12 @@ pub fn export(pin_config: &PinConfig, symlink_root: Option<&str>) -> Result<()>
         // set the pin direction
         pin_config
             .get_pin()
-            .set_direction(pin_config.direction.clone())?;
+            .set_direction(pin_config.direction)?;
 
         // set active low directio
         pin_config
             .get_pin()
-            .set_active_low(pin_config.active_low.clone())?;
+            .set_active_low(pin_config.active_low)?;
 
         // create symlink for each name
         for name in &pin_config.names {

src/main.rs

@@ -165,8 +165,8 @@ fn main() {
             let poll_options = GpioPollOptions {
                 gpio_opts: gpio_options,
                 edge: m.value_of("edge").unwrap_or("both"),
-                timeout: timeout,
                 pin: m.value_of("pin").unwrap(),
+                timeout,
             };
             gpio_poll::main(&cfg, &poll_options);
         }