Skip to content

Commit 5209452

Browse files
authored
Merge pull request #660 from rust-embedded/fix-weird-iterator-abuse
nb: do not swallow errors in fmt::Write.
2 parents 72fbbe7 + 45f6a64 commit 5209452

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

embedded-hal-nb/src/serial.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,9 @@ where
124124
{
125125
#[inline]
126126
fn write_str(&mut self, s: &str) -> core::fmt::Result {
127-
let _ = s
128-
.bytes()
129-
.map(|c| nb::block!(self.write(Word::from(c))))
130-
.next_back();
127+
for c in s.bytes() {
128+
nb::block!(self.write(Word::from(c))).map_err(|_| core::fmt::Error)?;
129+
}
131130
Ok(())
132131
}
133132
}

0 commit comments

Comments
 (0)