Skip to content

Commit b519ee5

Browse files
bors[bot]sirhcel
andauthored
Merge #344
344: Fix building docs and add CI check r=eldruin a=sirhcel Declaring `panic-halt` as a depencency works fine for building the example code but it makes `cargo doc` fail due to the duplicate lang item `panic_impl`. This issue got already reported with #314 and gets fixed by this PR by simply removing the unused `panic-halt` handler. Co-authored-by: Christian Meusel <christian.meusel@posteo.de>
2 parents 27e1439 + 180b40f commit b519ee5

File tree

5 files changed

+13
-4
lines changed

5 files changed

+13
-4
lines changed

.github/workflows/ci.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,19 @@ jobs:
3232
working-directory: src/${{ matrix.chapter }}
3333
run: cargo build
3434

35+
# Check a build succeeds for docs.
36+
build-doc:
37+
runs-on: ubuntu-20.04
38+
steps:
39+
- uses: actions/checkout@v2
40+
- uses: actions-rs/toolchain@v1
41+
with:
42+
profile: minimal
43+
toolchain: stable
44+
target: thumbv7em-none-eabihf
45+
- name: Build docs
46+
run: cargo doc
47+
3548
# Build the book HTML itself and optionally publish it.
3649
build-book:
3750
runs-on: ubuntu-20.04

src/05-led-roulette/auxiliary/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,4 @@ version = "0.2.0"
1212
cortex-m = "0.6.4"
1313
cortex-m-rt = "0.6.13"
1414
stm32f3-discovery = "0.6.0"
15-
panic-halt = "0.2.0"
1615
panic-itm = "0.4.2"

src/05-led-roulette/build-it.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ $ cargo build --target thumbv7em-none-eabihf
5757
Compiling cfg-if v1.0.0
5858
Compiling paste v1.0.4
5959
Compiling stm32f3-discovery v0.6.0
60-
Compiling panic-halt v0.2.0
6160
Compiling embedded-dma v0.1.2
6261
Compiling volatile-register v0.2.0
6362
Compiling nb v0.1.3

src/06-hello-world/auxiliary/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,4 @@ version = "0.2.0"
1111
cortex-m = "0.6.4"
1212
cortex-m-rt = "0.6.13"
1313
stm32f3-discovery = "0.5.0"
14-
panic-halt = "0.2.0"
1514
panic-itm = "0.4.2"

src/07-registers/auxiliary/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ version = "0.2.0"
1111
cortex-m = "0.6.4"
1212
cortex-m-rt = "0.6.13"
1313
stm32f3-discovery = "0.6.0"
14-
panic-halt = "0.2.0"
1514
panic-itm = "0.4.2"
1615

1716
[dependencies.stm32f3]

0 commit comments

Comments
 (0)