Merge pull request #182 from rodoufu/code_imp

Updating libraries and small code improvements

Author: apoelstra

Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 
 name = "secp256k1"
-version = "0.16.0"
+version = "0.16.1"
 authors = [ "Dawid Ciężarkiewicz <dpc@ucore.info>",
             "Andrew Poelstra <apoelstra@wpsoftware.net>" ]
 license = "CC0-1.0"
@@ -65,4 +65,4 @@ name = "sign_verify"
 
 [[example]]
 name = "generate_keys"
-required-features = ["rand"]
+required-features = ["rand"]

src/key.rs

@@ -619,13 +619,13 @@ mod test {
             fn next_u64(&mut self) -> u64 {
                 self.next_u32() as u64
             }
-            fn try_fill_bytes(&mut self, _dest: &mut [u8]) -> Result<(), Error> {
-                Err(Error::new(ErrorKind::Unavailable, "not implemented"))
-            }
-
             fn fill_bytes(&mut self, dest: &mut [u8]) {
                 impls::fill_bytes_via_next(self, dest);
             }
+
+            fn try_fill_bytes(&mut self, _dest: &mut [u8]) -> Result<(), Error> {
+                Err(Error::new(ErrorKind::Unavailable, "not implemented"))
+            }
         }
 
         let s = Secp256k1::new();

src/lib.rs

@@ -247,6 +247,9 @@ impl SerializedSignature {
     pub fn from_signature(sig: &Signature) -> SerializedSignature {
         sig.serialize_der()
     }
+
+    /// Check if the space is zero.
+    pub fn is_empty(&self) -> bool { self.len() == 0 }
 }
 
 impl Signature {
@@ -548,7 +551,7 @@ impl Default for SerializedSignature {
 
 impl PartialEq for SerializedSignature {
     fn eq(&self, other: &SerializedSignature) -> bool {
-        &self.data[..self.len] == &other.data[..other.len]
+        self.data[..self.len] == other.data[..other.len]
     }
 }
 

src/macros.rs

@@ -147,9 +147,9 @@ macro_rules! impl_pretty_debug {
     ($thing:ident) => {
         impl ::core::fmt::Debug for $thing {
             fn fmt(&self, f: &mut ::core::fmt::Formatter) -> ::core::fmt::Result {
-                try!(write!(f, "{}(", stringify!($thing)));
+                write!(f, "{}(", stringify!($thing))?;
                 for i in self[..].iter().cloned() {
-                    try!(write!(f, "{:02x}", i));
+                    write!(f, "{:02x}", i)?;
                 }
                 write!(f, ")")
             }
@@ -162,7 +162,7 @@ macro_rules! impl_raw_debug {
         impl ::core::fmt::Debug for $thing {
             fn fmt(&self, f: &mut ::core::fmt::Formatter) -> ::core::fmt::Result {
                 for i in self[..].iter().cloned() {
-                    try!(write!(f, "{:02x}", i));
+                    write!(f, "{:02x}", i)?;
                 }
                 Ok(())
             }