Skip to content

Commit 9304908

Browse files
committed
Fix 1.29 tests by pinning newly-incompatible crates
1 parent bca5ff1 commit 9304908

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,11 @@ Because some dependencies have broken the build in minor/patch releases, to
5353
compile with 1.29.0 you will need to run the following version-pinning command:
5454
```
5555
cargo update --package "cc" --precise "1.0.41"
56+
cargo update --package "log:0.4.x" --precise "0.4.13" # x being the highest patch version
5657
cargo update --package "cfg-if" --precise "0.1.9"
5758
cargo update --package "unicode-normalization" --precise "0.1.9"
5859
cargo update --package "serde_json" --precise "1.0.39"
5960
cargo update --package "serde" --precise "1.0.98"
6061
cargo update --package "serde_derive" --precise "1.0.98"
62+
cargo update --package "byteorder" --precise "1.3.4"
6163
```

contrib/test.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ echo "PATH: \"$PATH\""
1111
# Pin dependencies for Rust v1.29
1212
if [ "$TRAVIS_RUST_VERSION" = "1.29.0" ]; then
1313
cargo generate-lockfile --verbose
14+
15+
# hyper depends on log 0.3 while we depnd on 0.4, so cargo doesn't know which one to pin
16+
LOG_4_PATCH="$(cargo update --package "log" --precise "0.4.13" 2>&1 | sed -n "s/.*log:0.4.\([0-9]*\)/\1/p")"
17+
cargo update --package "log:0.4.$LOG_4_PATCH" --precise "0.4.13"
18+
1419
cargo update --verbose --package "cc" --precise "1.0.41"
1520
cargo update --verbose --package "cfg-if" --precise "0.1.9"
1621
cargo update --verbose --package "unicode-normalization" --precise "0.1.9"

0 commit comments

Comments
 (0)