Merge #147: Rename EncodeError::Write variant to Fmt

3e729c3 Rename EncodeError::Write variant to Fmt (Tobin C. Harding)

Pull request description:

  We typically refer to a "fmt" being an object that implements `fmt::Write` e.g, `encode_to_fmt()`.

  Currently we are using the variant name `Write` for an error variant that holds a `fmt::Error`, while this is correct in a way it is also confusing because we may one day have an `io::Error` (coming from a `io::Write` writer).

  Use `EncodeError::Fmt` instead of `Write`.

ACKs for top commit:
  apoelstra:
    ACK 3e729c3

Tree-SHA512: 35073fe871830a15762e541547ef7e0fcbd18ef6aabe0bdd84a0c6bfadea65eb345482f6c0275f3497a30ae2c994454a18a29e22386cb94b67a6fe735a9d8ff5

Author: apoelstra

src/segwit.rs

@@ -297,7 +297,7 @@ pub enum EncodeError {
     /// Invalid witness length.
     WitnessLength(WitnessLengthError),
     /// Writing to formatter failed.
-    Write(fmt::Error),
+    Fmt(fmt::Error),
 }
 
 impl fmt::Display for EncodeError {
@@ -307,7 +307,7 @@ impl fmt::Display for EncodeError {
         match *self {
             WitnessVersion(ref e) => write_err!(f, "witness version"; e),
             WitnessLength(ref e) => write_err!(f, "witness length"; e),
-            Write(ref e) => write_err!(f, "writing to formatter failed"; e),
+            Fmt(ref e) => write_err!(f, "writing to formatter failed"; e),
         }
     }
 }
@@ -320,7 +320,7 @@ impl std::error::Error for EncodeError {
         match *self {
             WitnessVersion(ref e) => Some(e),
             WitnessLength(ref e) => Some(e),
-            Write(ref e) => Some(e),
+            Fmt(ref e) => Some(e),
         }
     }
 }
@@ -337,7 +337,7 @@ impl From<WitnessLengthError> for EncodeError {
 
 impl From<fmt::Error> for EncodeError {
     #[inline]
-    fn from(e: fmt::Error) -> Self { Self::Write(e) }
+    fn from(e: fmt::Error) -> Self { Self::Fmt(e) }
 }
 
 #[cfg(all(test, feature = "alloc"))]