Improve import_descriptors test

The current test of the RPC always returns true due to scanning for the
timestamp `now`.

Improve the test to be more thorough by creating a new address and then
scanning for the descriptor at a later time.

Author: jamillambert

integration_test/tests/wallet.rs

@@ -314,20 +314,53 @@ fn wallet__import_address() {
 #[cfg(not(feature = "v20_and_below"))]
 fn wallet__import_descriptors() {
     use node::{serde_json, ImportDescriptorsRequest};
+    use std::time::{SystemTime, UNIX_EPOCH};
 
     let node = Node::with_wallet(Wallet::None, &[]);
     let wallet_name = "desc_wallet";
+
+    #[cfg(feature = "v22_and_below")]
     node.client.create_wallet_with_descriptors(wallet_name).expect("create descriptor wallet");
 
-    let address = node.client.new_address().expect("failed to get new address");
-    let descriptor = format!("addr({})", address);
+    // v23 onwards uses descriptor wallets by default.
+    #[cfg(not(feature = "v22_and_below"))]
+    node.client.create_wallet(wallet_name).expect("create wallet");
+
+    node.fund_wallet();
+
+    // 1. Get the current time
+    let start_time = SystemTime::now()
+        .duration_since(UNIX_EPOCH)
+        .expect("failed to get current time")
+        .as_secs();
+
+    // 2. Use a known private key, derive the address from it and send some coins to it.
+    let privkey =
+        PrivateKey::from_wif("cVt4o7BGAig1UXywgGSmARhxMdzP5qvQsxKkSsc1XEkw3tDTQFpy").unwrap();
+    let secp = bitcoin::secp256k1::Secp256k1::new();
+    let pubkey = privkey.public_key(&secp);
+    let address = bitcoin::Address::p2pkh(pubkey, privkey.network);
+    let amount = bitcoin::Amount::from_sat(10_000);
+    let _txid = node.client.send_to_address(&address, amount).expect("sendtoaddress");
+
+    // 3. Get the descriptor from the private key.
+    let raw_descriptor = format!("wpkh({})", privkey.to_wif());
+    let info = node.client.get_descriptor_info(&raw_descriptor).expect("get_descriptor_info");
+    let descriptor = format!("{}#{}", raw_descriptor, info.checksum);
+
+    // 4. Mine 100 blocks
+    let mining_address = node.client.new_address().expect("failed to get mining address");
+    let _blocks = node.client.generate_to_address(100, &mining_address).expect("generatetoaddress");
 
+    // 5. Scan for the descriptor using the time from (1)
     let request = ImportDescriptorsRequest {
         desc: descriptor,
-        timestamp: serde_json::Value::String("now".to_string()),
+        timestamp: serde_json::Value::Number(serde_json::Number::from(start_time)),
     };
 
-    let _: ImportDescriptors = node.client.import_descriptors(&[request]).expect("importdescriptors");
+    let result: ImportDescriptors = node.client.import_descriptors(&[request]).expect("importdescriptors");
+    assert_eq!(result.0.len(), 1, "should have exactly one import result");
+    assert!(result.0[0].success);
 }
 
 #[test]