Replies: 1 comment
-
Thanks @Izukimat. Yea improved kwargs propagation would be great. Have any ideas on you might do this? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Context and Code Example:
I have been working with the MilvusVectorStore, and I observed a pattern that seems prevalent in other vector store implementations as well. The query method in these classes doesn't utilize additional arguments passed via kwargs to influence query parameters like output_fields. Following is a code snippet from the MilvusVectorStore for illustration:
In this implementation,
output_fields
and similar parameters are sourced directly from the query object. This means that even if I pass output_fields dynamically through kwargs, it has no effect on query.output_fields or the behaviour of the method.Question and Possible Contribution:
Dynamic Parameter Handling: Is there a preferred approach or existing mechanism to dynamically set properties like output_fields for a query, especially when using kwargs?
Initial Setting of query.output_fields: How is query.output_fields initially set or determined within the query method?
If this is an area open for enhancement, I am interested in contributing by extending the query methods to better handle dynamic parameters via kwargs. Are there any considerations I should be aware of in this process?
Beta Was this translation helpful? Give feedback.
All reactions