render: Remove RenderBackend::replace_shape

Author: Dinnerbone

core/src/drawing.rs

@@ -304,12 +304,8 @@ impl Drawing {
                 edge_bounds: self.edge_bounds.clone(),
                 id: 0,
             };
-            if let Some(handle) = self.render_handle.get() {
-                context.renderer.replace_shape(shape, self, handle);
-            } else {
-                self.render_handle
-                    .set(Some(context.renderer.register_shape(shape, self)));
-            }
+            self.render_handle
+                .set(Some(context.renderer.register_shape(shape, self)));
         }
 
         if let Some(handle) = self.render_handle.get() {

render/canvas/src/lib.rs

@@ -445,16 +445,6 @@ impl RenderBackend for WebCanvasRenderBackend {
         handle
     }
 
-    fn replace_shape(
-        &mut self,
-        shape: DistilledShape,
-        bitmap_source: &dyn BitmapSource,
-        handle: ShapeHandle,
-    ) {
-        let data = swf_shape_to_canvas_commands(&shape, bitmap_source, self);
-        self.shapes[handle.0] = data;
-    }
-
     fn register_glyph_shape(&mut self, glyph: &swf::Glyph) -> ShapeHandle {
         let shape = ruffle_render::shape_utils::swf_glyph_to_shape(glyph);
         self.register_shape((&shape).into(), &NullBitmapSource)

render/src/backend.rs

@@ -24,12 +24,6 @@ pub trait RenderBackend: Downcast {
         shape: DistilledShape,
         bitmap_source: &dyn BitmapSource,
     ) -> ShapeHandle;
-    fn replace_shape(
-        &mut self,
-        shape: DistilledShape,
-        bitmap_source: &dyn BitmapSource,
-        handle: ShapeHandle,
-    );
     fn register_glyph_shape(&mut self, shape: &swf::Glyph) -> ShapeHandle;
 
     /// Creates a new `RenderBackend` which renders directly

render/src/backend/null.rs

@@ -50,13 +50,6 @@ impl RenderBackend for NullRenderer {
     ) -> ShapeHandle {
         ShapeHandle(0)
     }
-    fn replace_shape(
-        &mut self,
-        _shape: DistilledShape,
-        _bitmap_source: &dyn BitmapSource,
-        _handle: ShapeHandle,
-    ) {
-    }
     fn register_glyph_shape(&mut self, _shape: &swf::Glyph) -> ShapeHandle {
         ShapeHandle(0)
     }

render/webgl/src/lib.rs

@@ -734,6 +734,7 @@ impl WebGlRenderBackend {
         };
     }
 
+    #[allow(dead_code)]
     fn delete_mesh(&self, mesh: &Mesh) {
         if let Some(gl2) = &self.gl2 {
             for draw in &mesh.draws {
@@ -996,19 +997,6 @@ impl RenderBackend for WebGlRenderBackend {
         handle
     }
 
-    fn replace_shape(
-        &mut self,
-        shape: DistilledShape,
-        bitmap_source: &dyn BitmapSource,
-        handle: ShapeHandle,
-    ) {
-        self.delete_mesh(&self.meshes[handle.0]);
-        match self.register_shape_internal(shape, bitmap_source) {
-            Ok(mesh) => self.meshes[handle.0] = mesh,
-            Err(e) => log::error!("Couldn't replace shape: {:?}", e),
-        }
-    }
-
     fn register_glyph_shape(&mut self, glyph: &swf::Glyph) -> ShapeHandle {
         let shape = ruffle_render::shape_utils::swf_glyph_to_shape(glyph);
         let handle = ShapeHandle(self.meshes.len());

render/wgpu/src/backend.rs

@@ -430,17 +430,6 @@ impl<T: RenderTarget + 'static> RenderBackend for WgpuRenderBackend<T> {
         handle
     }
 
-    #[instrument(level = "debug", skip_all)]
-    fn replace_shape(
-        &mut self,
-        shape: DistilledShape,
-        bitmap_source: &dyn BitmapSource,
-        handle: ShapeHandle,
-    ) {
-        let mesh = self.register_shape_internal(shape, bitmap_source);
-        self.meshes[handle.0] = mesh;
-    }
-
     #[instrument(level = "debug", skip_all)]
     fn register_glyph_shape(&mut self, glyph: &swf::Glyph) -> ShapeHandle {
         let shape = ruffle_render::shape_utils::swf_glyph_to_shape(glyph);