Make Node#obscured? support nested iframes

Author: myabc

lib/capybara/cuprite/browser.rb

@@ -218,7 +218,7 @@ def obscured?(node, x = nil, y = nil)
                 end
         return true if value == true
 
-        false
+        frame_obscured_at?(*value.values_at("x", "y"))
       end
 
       def all_text(node)
@@ -268,6 +268,22 @@ def attach_page(target_id = nil)
         target.page = Page.new(target.client, context_id: target.context_id, target_id: target.id)
         target.page
       end
+
+      def frame_obscured_at?(x, y)
+        frame = page.active_frame
+        return false if frame.main?
+
+        parent_frame = page.frame_by(id: frame.parent_id)
+        frame_node = parent_frame&.at_xpath("//iframe[@id=\"#{frame.name}\"]")
+        return false unless frame_node
+
+        switch_to_frame(:parent)
+        begin
+          obscured?(frame_node, x, y)
+        ensure
+          switch_to_frame(frame)
+        end
+      end
     end
   end
 end

lib/capybara/cuprite/page.rb

@@ -138,6 +138,14 @@ def closed?
         false
       end
 
+      def active_frame
+        if @frame_stack.empty?
+          main_frame
+        else
+          @frames[@frame_stack.last]
+        end
+      end
+
       private
 
       def prepare_page
@@ -180,14 +188,6 @@ def find_position(node, **options)
 
         raise
       end
-
-      def active_frame
-        if @frame_stack.empty?
-          main_frame
-        else
-          @frames[@frame_stack.last]
-        end
-      end
     end
   end
 end

spec/spec_helper.rb

@@ -37,7 +37,6 @@ module TestSessions
 RSpec.configure do |config|
   config.define_derived_metadata do |metadata|
     regexes = <<~REGEXP.split("\n").map { |s| Regexp.quote(s.strip) }.join("|")
-      node #obscured? should work in nested iframes
       node #drag_to should work with jsTree
       node #drag_to should drag and drop an object
       node #drag_to should drag and drop if scrolling is needed