Skip to content

Commit 1957624

Browse files
committed
fix: build
1 parent 70768db commit 1957624

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

.github/workflows/tests.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
fail-fast: false
1313
matrix:
14-
ruby: [2.7, "3.0", 3.1, 3.2, 3.3]
14+
ruby: ["2.7", "3.0", "3.1", "3.2", "3.3", "3.4"]
1515
runs-on: ubuntu-latest
1616
env:
1717
FERRUM_PROCESS_TIMEOUT: 25
@@ -31,6 +31,11 @@ jobs:
3131
with:
3232
chrome-version: stable
3333

34+
- name: Fix GA Chrome Permissions
35+
run: |
36+
sudo chown root:root /opt/hostedtoolcache/setup-chrome/chromium/stable/x64/chrome-sandbox
37+
sudo chmod 4755 /opt/hostedtoolcache/setup-chrome/chromium/stable/x64/chrome-sandbox
38+
3439
- name: Run tests
3540
run: |
3641
mkdir -p /tmp/cuprite

cuprite.gemspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@ Gem::Specification.new do |s|
2424

2525
s.required_ruby_version = ">= 2.7.0"
2626

27-
s.add_runtime_dependency "capybara", "~> 3.0"
28-
s.add_runtime_dependency "ferrum", "~> 0.16.0"
27+
s.add_dependency "capybara", "~> 3.0"
28+
s.add_dependency "ferrum", "~> 0.16.0"
2929
end

lib/capybara/cuprite/driver.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,8 @@ def set_cookie(name, value, options = {})
251251

252252
def remove_cookie(name, **options)
253253
options[:domain] = default_domain if options.empty?
254-
browser.cookies.remove(**options.merge(name: name))
254+
options = options.merge(name: name)
255+
browser.cookies.remove(**options)
255256
end
256257

257258
def clear_cookies

0 commit comments

Comments
 (0)