Skip to content

Commit 150d9a4

Browse files
committed
Do not modify time input value in JS
1 parent 7ae91d8 commit 150d9a4

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

lib/capybara/cuprite/javascripts/index.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,12 +127,9 @@ class Cuprite {
127127
this.trigger(node, "focus");
128128
this.setValue(node, "");
129129

130-
if (node.type == "number" || node.type == "date" || node.type == "range") {
130+
if (node.type == "number" || node.type == "date" || node.type == "range" || node.type == "time") {
131131
this.setValue(node, value);
132132
this.input(node);
133-
} else if (node.type == "time") {
134-
this.setValue(node, new Date(value).toTimeString().split(" ")[0]);
135-
this.input(node);
136133
} else if (node.type == "datetime-local") {
137134
value = new Date(value);
138135
let year = value.getFullYear();

lib/capybara/cuprite/node.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ def set(value, options = {})
105105
node.evaluate("this.setAttribute('value', '#{value}')")
106106
when "time"
107107
value = value.strftime("%H:%M") if value.is_a?(Time)
108-
node.evaluate("this.setAttribute('value', '#{value}')")
108+
command(:set, value.to_s)
109109
else
110110
command(:set, value.to_s)
111111
end

0 commit comments

Comments
 (0)