-
Notifications
You must be signed in to change notification settings - Fork 221
Description
Hi!
Two questions:
First, I'd like folks to be able to typecheck their Gemfiles via Solargraph, which is able to use RBS for external types. The DSL for a Gemfile is described in Bundler::Dsl; having types described for that class is certainly a prerequisite.
Are you open to having types for bundler live in this project, presumably in core next to rubygems?
If not, Solargraph rbs collection, but it doesn't seem possible to add bundler via gem_rbs_collection, as rbs collection install
only takes effect on gems.
Second, there are a number of public APIs in both bundler and rubygems that Solargraph uses in its own code that are not in the RBS repo. It appears you had the same issue, as I see shims for bundler and rubygems in your sig/shims directory.
Do you object to me adding these additional signatures to the definitions in https://github.com/ruby/rbs/tree/master/core? I was not sure if there was intent behind the decision to leave those as internal shims or if it was for expedience.
Much appreciation for your work on RBS! Solargraph is much more capable as a result, both as an LSP and a typechecker.