Fix lambda style

Author: etehtsea

.rubocop_todo.yml

@@ -41,10 +41,6 @@ Style/Documentation:
 Style/FileName:
   Enabled: false
 
-# Offense count: 16
-Style/Lambda:
-  Enabled: false
-
 # Offense count: 1
 # Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
 Style/Next:

spec/grape_entity/entity_spec.rb

@@ -70,7 +70,7 @@ class BogusEntity < Grape::Entity
 
         context 'with parameters passed to the block' do
           it 'sets the :proc option in the exposure options' do
-            block = lambda { |_| true }
+            block = ->(_) { true }
             subject.expose :name, using: 'Awesome', &block
             expect(subject.exposures[:name]).to eq(proc: block, using: 'Awesome')
           end
@@ -112,8 +112,8 @@ class BogusEntity < Grape::Entity
 
           it 'does not represent nested exposures whose conditions are not met' do
             subject.expose :awesome do
-              subject.expose(:condition_met, if: lambda { |_, _| true }) { |_| 'value' }
-              subject.expose(:condition_not_met, if: lambda { |_, _| false }) { |_| 'value' }
+              subject.expose(:condition_met, if: ->(_, _) { true }) { |_| 'value' }
+              subject.expose(:condition_not_met, if: ->(_, _) { false }) { |_| 'value' }
             end
 
             expect(subject.represent({}).send(:value_for, :awesome)).to eq(condition_met: 'value')
@@ -228,7 +228,7 @@ class Parent < Person
       end
 
       context 'register formatters' do
-        let(:date_formatter) { lambda { |date| date.strftime('%m/%d/%Y') } }
+        let(:date_formatter) { ->(date) { date.strftime('%m/%d/%Y') } }
 
         it 'registers a formatter' do
           subject.format_with :timestamp, &date_formatter
@@ -261,7 +261,7 @@ class Parent < Person
         it 'formats an exposure with a :format_with lambda that returns a value from the entity instance' do
           object = {}
 
-          subject.expose(:size, format_with: lambda { |_value| self.object.class.to_s })
+          subject.expose(:size, format_with: ->(_value) { self.object.class.to_s })
           expect(subject.represent(object).send(:value_for, :size)).to eq object.class.to_s
         end
 
@@ -364,7 +364,7 @@ class Parent < Person
       end
 
       it 'merges nested :if option' do
-        match_proc = lambda { |_obj, _opts| true }
+        match_proc = ->(_obj, _opts) { true }
 
         subject.class_eval do
           # Symbol
@@ -389,7 +389,7 @@ class Parent < Person
       end
 
       it 'merges nested :unless option' do
-        match_proc = lambda { |_, _| true }
+        match_proc = ->(_, _) { true }
 
         subject.class_eval do
           # Symbol
@@ -433,10 +433,10 @@ class Parent < Person
       end
 
       it 'overrides nested :proc option' do
-        match_proc = lambda { |_obj, _opts| 'more awesomer' }
+        match_proc = ->(_obj, _opts) { 'more awesomer' }
 
         subject.class_eval do
-          with_options(proc: lambda { |_obj, _opts| 'awesome' }) do
+          with_options(proc: ->(_obj, _opts) { 'awesome' }) do
             expose :awesome_thing, proc: match_proc
           end
         end
@@ -773,8 +773,8 @@ class Parent < Person
 
         it "does not expose attributes that don't exist on the object, even with criteria" do
           fresh_class.expose :email
-          fresh_class.expose :nonexistent_attribute, safe: true, if: lambda { false }
-          fresh_class.expose :nonexistent_attribute2, safe: true, if: lambda { true }
+          fresh_class.expose :nonexistent_attribute, safe: true, if: -> { false }
+          fresh_class.expose :nonexistent_attribute2, safe: true, if: -> { true }
 
           res = fresh_class.new(model).serializable_hash
           expect(res).to have_key :email
@@ -799,8 +799,8 @@ class Parent < Person
 
         it 'does not expose attributes that are generated by a block but have not passed criteria' do
           fresh_class.expose :nonexistent_attribute,
-                             proc: lambda { |_model, _opts| 'I exist, but it is not yet my time to shine' },
-                             if: lambda { |_model, _opts| false }
+                             proc: ->(_model, _opts) { 'I exist, but it is not yet my time to shine' },
+                             if: ->(_model, _opts) { false }
           res = fresh_class.new(model).serializable_hash
           expect(res).not_to have_key :nonexistent_attribute
         end
@@ -821,8 +821,8 @@ class TestEntity < Grape::Entity
 
       it 'does not expose attributes that are generated by a block but have not passed criteria' do
         fresh_class.expose :nonexistent_attribute,
-                           proc: lambda { |_, _| 'I exist, but it is not yet my time to shine' },
-                           if: lambda { |_, _| false }
+                           proc: ->(_, _) { 'I exist, but it is not yet my time to shine' },
+                           if: ->(_, _) { false }
         res = fresh_class.new(model).serializable_hash
         expect(res).not_to have_key :nonexistent_attribute
       end
@@ -901,7 +901,7 @@ def timestamp(date)
             date.strftime('%m/%d/%Y')
           end
 
-          expose :fantasies, format_with: lambda { |f| f.reverse }
+          expose :fantasies, format_with: ->(f) { f.reverse }
         end
       end
 
@@ -1238,7 +1238,7 @@ class UserEntity < Grape::Entity
       end
 
       it 'only passes through proc :if exposure if it returns truthy value' do
-        exposure_options = { if: lambda { |_, opts| opts[:true] } }
+        exposure_options = { if: ->(_, opts) { opts[:true] } }
 
         expect(subject.send(:conditions_met?, exposure_options, true: false)).to be false
         expect(subject.send(:conditions_met?, exposure_options, true: true)).to be true
@@ -1256,7 +1256,7 @@ class UserEntity < Grape::Entity
       end
 
       it 'only passes through proc :unless exposure if it returns falsy value' do
-        exposure_options = { unless: lambda { |_, options| options[:true] == true } }
+        exposure_options = { unless: ->(_, opts) { opts[:true] == true } }
 
         expect(subject.send(:conditions_met?, exposure_options, true: false)).to be true
         expect(subject.send(:conditions_met?, exposure_options, true: true)).to be false