Skip to content

Commit e54d639

Browse files
authored
Merge pull request #12 from sue445/refactor
Refactoring
2 parents 3539ab6 + 7f8830d commit e54d639

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

lib/ruby_header_parser/parser.rb

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,18 @@ class Parser # rubocop:disable Metrics/ClassLength
1919
# @return [RubyHeaderParser::Data]
2020
attr_reader :data
2121

22+
DEFAULT_HEADER_FILE = "#{RbConfig::CONFIG["rubyhdrdir"]}/ruby.h".freeze
23+
24+
DEFAULT_INCLUDE_PATHS = [
25+
RbConfig::CONFIG["rubyarchhdrdir"],
26+
RbConfig::CONFIG["rubyhdrdir"],
27+
].freeze
28+
2229
# @param header_file [String] path to ruby.h
2330
# @param include_paths [Array<String>]
2431
# @param dist_preprocessed_header_file [String]
25-
def initialize(dist_preprocessed_header_file:, header_file: "#{RbConfig::CONFIG["rubyhdrdir"]}/ruby.h",
26-
include_paths: [RbConfig::CONFIG["rubyarchhdrdir"], RbConfig::CONFIG["rubyhdrdir"]])
32+
def initialize(dist_preprocessed_header_file:, header_file: DEFAULT_HEADER_FILE,
33+
include_paths: DEFAULT_INCLUDE_PATHS)
2734
@header_file = header_file
2835
@include_paths = include_paths
2936
@dist_preprocessed_header_file = dist_preprocessed_header_file

sig/ruby_header_parser/parser.rbs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ module RubyHeaderParser
55
attr_reader dist_preprocessed_header_file: String
66
attr_reader data: Data
77

8+
DEFAULT_HEADER_FILE: String
9+
DEFAULT_INCLUDE_PATHS: Array[String]
10+
811
def initialize: (
912
dist_preprocessed_header_file: String,
1013
?header_file: String,

spec/ruby_header_parser_spec.rb

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)