nits: Extract to generate_function_definition_from_line

Author: sue445

_tools/ruby_h_to_go/lib/ruby_header_parser/parser.rb

@@ -104,33 +104,42 @@ def extract_enum_definitions
     def __extract_function_definitions(c_kinds:, kind:, is_parse_multiline_definition:)
       stdout = execute_ctags("--c-kinds=#{c_kinds} --fields=+nS --extras=+q")
 
-      stdout.each_line.with_object([]) do |line, definitions|
-        parts = line.split("\t")
+      stdout.each_line.map do |line|
+        generate_function_definition_from_line(line:, kind:, is_parse_multiline_definition:)
+      end.compact.uniq(&:name)
+    end
+
+    # @param line [String]
+    # @param kind [String]
+    # @param is_parse_multiline_definition [Boolean]
+    #
+    # @param [Array<RubyHeaderParser::FunctionDefinition>, nil]
+    def generate_function_definition_from_line(line:, kind:, is_parse_multiline_definition:)
+      parts = line.split("\t")
 
-        function_name = parts[0]
-        filepath = parts[1]
+      function_name = parts[0]
+      filepath = parts[1]
 
-        next unless data.should_generate_function?(function_name)
+      return nil unless data.should_generate_function?(function_name)
 
-        next unless parts[3] == kind
+      return nil unless parts[3] == kind
 
-        line_num = Util.find_field(parts, "line").to_i
-        definition = parse_function_definition(filepath:, pattern: parts[2], line_num:, is_parse_multiline_definition:)
+      line_num = Util.find_field(parts, "line").to_i
+      definition = parse_function_definition(filepath:, pattern: parts[2], line_num:, is_parse_multiline_definition:)
 
-        args = parse_definition_args(function_name, Util.find_field(parts, "signature"))
+      args = parse_definition_args(function_name, Util.find_field(parts, "signature"))
 
-        # Exclude functions with variable-length arguments
-        next if args&.last&.type == "..."
+      # Exclude functions with variable-length arguments
+      return nil if args&.last&.type == "..."
 
-        typeref_field = Util.find_field(parts, "typeref:typename")
+      typeref_field = Util.find_field(parts, "typeref:typename")
 
-        definitions << FunctionDefinition.new(
-          definition:,
-          name:       function_name,
-          typeref:    create_typeref(definition:, function_name:, typeref_field:, filepath:, line_num:),
-          args:,
-        )
-      end.uniq(&:name)
+      FunctionDefinition.new(
+        definition:,
+        name:       function_name,
+        typeref:    create_typeref(definition:, function_name:, typeref_field:, filepath:, line_num:),
+        args:,
+      )
     end
 
     # @param args [String]