Merge pull request #129 from sue445/fix_rubocop

Fix rubocop

Author: sue445

.github/workflows/build.yml

@@ -12,7 +12,6 @@ on:
     paths-ignore:
       - ".github/workflows/patch_for_go_gem.yml"
       - "_benchmark/**"
-      - "_tools/**"
 
 env:
   TEST_ARGS: -coverprofile coverage.out -covermode atomic

_tools/ruby_h_to_go/lib/ruby_header_parser/parser.rb

@@ -19,7 +19,7 @@ def initialize(header_dir)
 
     # @return [Array<RubyHeaderParser::FunctionDefinition>]
     def extract_function_definitions
-      stdout = `ctags --recurse --c-kinds=p --languages=C --language-force=C --fields=+nS --extras=+q -f - #{header_dir}`
+      stdout = `ctags --recurse --c-kinds=p --languages=C --language-force=C --fields=+nS --extras=+q -f - #{header_dir}` # rubocop:disable Layout/LineLength
 
       stdout.each_line.with_object([]) do |line, definitions|
         parts = line.split("\t")
@@ -43,20 +43,11 @@ def extract_function_definitions
         # Exclude functions with variable-length arguments
         next if args&.last&.type == "..."
 
-        typeref_type = definition[0...definition.index(parts[0])].gsub("char *", "char*").strip
-        typeref_pointer = nil
-        if typeref_type.match?(/\*+$/)
-          typeref_type = typeref_type.gsub(/\*+$/, "").strip
-          typeref_pointer = :ref
-        end
-
-        typeref = TyperefDefinition.new(type: typeref_type, pointer: typeref_pointer)
-
         definitions << FunctionDefinition.new(
           definition:,
           name:       parts[0],
           filepath:   parts[1],
-          typeref:,
+          typeref:    create_typeref(definition, function_name),
           args:,
         )
       end
@@ -248,5 +239,19 @@ def function_arg_pointer_hint(function_name, index)
 
       :ref
     end
+
+    # @param definition [String]
+    # @param function_name [String]
+    # @return [RubyHeaderParser::TyperefDefinition]
+    def create_typeref(definition, function_name)
+      typeref_type = definition[0...definition.index(function_name)].gsub("char *", "char*").strip
+      typeref_pointer = nil
+      if typeref_type.match?(/\*+$/)
+        typeref_type = typeref_type.gsub(/\*+$/, "").strip
+        typeref_pointer = :ref
+      end
+
+      TyperefDefinition.new(type: typeref_type, pointer: typeref_pointer)
+    end
   end
 end

_tools/ruby_h_to_go/spec/ruby_header_parser/parser_spec.rb

@@ -78,7 +78,7 @@
       end
 
       its(:name)       { should eq "rb_tracepoint_new" }
-      its(:definition) { should eq "VALUE rb_tracepoint_new(VALUE target_thread_not_supported_yet, rb_event_flag_t events, void (*func)(VALUE, void *), void *data)" }
+      its(:definition) { should eq "VALUE rb_tracepoint_new(VALUE target_thread_not_supported_yet, rb_event_flag_t events, void (*func)(VALUE, void *), void *data)" } # rubocop:disable Layout/LineLength
       its(:filepath)   { should be_end_with "/ruby/debug.h" }
       its(:typeref)    { should eq typedef(type: "VALUE") }
       its(:args)       { should eq args }

_tools/ruby_h_to_go/spec/ruby_header_parser/util_spec.rb

@@ -25,13 +25,33 @@
     context "simple case" do
       let(:signature) { "VALUE obj, ID mid, int argc, const VALUE *argv, rb_block_call_func_t proc, VALUE data2" }
 
-      it { should eq ["VALUE obj", "ID mid", "int argc", "const VALUE *argv", "rb_block_call_func_t proc", "VALUE data2"] }
+      let(:args) do
+        [
+          "VALUE obj",
+          "ID mid",
+          "int argc",
+          "const VALUE *argv",
+          "rb_block_call_func_t proc",
+          "VALUE data2",
+        ]
+      end
+
+      it { should eq args }
     end
 
     context "with function pointer" do
-      let(:signature) { "VALUE target_thread_not_supported_yet,rb_event_flag_t events,void (* func)(VALUE,void *),void * data" }
-
-      it { should eq ["VALUE target_thread_not_supported_yet", "rb_event_flag_t events", "void (* func)(VALUE,void *)", "void * data"] }
+      let(:signature) { "VALUE target_thread_not_supported_yet,rb_event_flag_t events,void (* func)(VALUE,void *),void * data" } # rubocop:disable Layout/LineLength
+
+      let(:args) do
+        [
+          "VALUE target_thread_not_supported_yet",
+          "rb_event_flag_t events",
+          "void (* func)(VALUE,void *)",
+          "void * data",
+        ]
+      end
+
+      it { should eq args }
     end
   end
 end