Skip to content

Commit 1c36179

Browse files
authored
Merge pull request #216 from ruby-go-gem/feature/suspress-empty-changes
Suppress empty content in CHANGELOG
2 parents 328b1df + 60010c5 commit 1c36179

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

CHANGELOG.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,13 @@
1010
* Add rbs to `go_gem` gem by @sue445 in https://github.com/ruby-go-gem/go-gem-wrapper/pull/215
1111
* Add rake task helper for go by @sue445 in https://github.com/ruby-go-gem/go-gem-wrapper/pull/214
1212

13-
### Other changes
14-
1513
## ruby_h_to_go
1614
* No changes
1715

1816
## Other
1917
### Bugfixes
2018
* Fix changelog_generator on CI by @sue445 in https://github.com/ruby-go-gem/go-gem-wrapper/pull/212
2119

22-
### Other changes
23-
2420
**Full Changelog**: https://github.com/ruby-go-gem/go-gem-wrapper/compare/v0.2.4...v0.3.0
2521

2622
# [v0.2.4](https://github.com/ruby-go-gem/go-gem-wrapper/releases/tag/v0.2.4) - 2024-11-16

_tools/changelog_generator/changelog_generator.rb

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,14 @@ def generate_category_changelog(prs) # rubocop:disable Metrics/AbcSize,Metrics/C
100100
found_pr_numbers.include?(pr["number"]) || pr["label_names"].include?("chore")
101101
end
102102

103-
lines << "### Other changes"
104-
other_prs.each do |pr|
105-
lines << generate_changelog_line(pr)
103+
unless other_prs.empty?
104+
lines << "### Other changes"
105+
other_prs.each do |pr|
106+
lines << generate_changelog_line(pr)
107+
end
108+
found_pr_numbers.push(*other_prs.map { |pr| pr["number"] })
109+
lines << ""
106110
end
107-
found_pr_numbers.push(*other_prs.map { |pr| pr["number"] })
108-
lines << ""
109111

110112
return "* No changes\n\n" if found_pr_numbers.empty?
111113

0 commit comments

Comments
 (0)