Merge pull request #1165 from fatkodima/fix-save_bang-parenthesis

Fix `Rails/SaveBang` to ignore parenthesis

Author: koic

changelog/fix_save_bang_to_ignore_parenthesis.md

@@ -0,0 +1 @@
+* [#1160](https://github.com/rubocop/rubocop-rails/issues/1160): Fix `Rails/SaveBang` to ignore parenthesis. ([@fatkodima][])

lib/rubocop/cop/rails/save_bang.rb

@@ -235,10 +235,10 @@ def check_used_in_condition_or_compound_boolean(node)
 
         def in_condition_or_compound_boolean?(node)
           node = node.block_node || node
-          parent = node.parent
+          parent = node.each_ancestor.find { |ancestor| !ancestor.begin_type? }
           return false unless parent
 
-          operator_or_single_negative?(parent) || (conditional?(parent) && node == parent.condition)
+          operator_or_single_negative?(parent) || (conditional?(parent) && node == deparenthesize(parent.condition))
         end
 
         def operator_or_single_negative?(node)
@@ -249,6 +249,11 @@ def conditional?(parent)
           parent.if_type? || parent.case_type?
         end
 
+        def deparenthesize(node)
+          node = node.children.last while node.begin_type?
+          node
+        end
+
         def checked_immediately?(node)
           node.parent && call_to_persisted?(node.parent)
         end

spec/rubocop/cop/rails/save_bang_spec.rb

@@ -170,6 +170,19 @@
       end
     end
 
+    it "when using #{method} wrapped within parenthesis with if" do
+      if update
+        expect_no_offenses(<<~RUBY, method: method)
+          if (object.#{method}); something; end
+        RUBY
+      else
+        expect_offense(<<~RUBY, method: method)
+          if (object.#{method}); something; end
+                     ^{method} `#{method}` returns a model which is always truthy.
+        RUBY
+      end
+    end
+
     it "when using #{method} with if with block" do
       if update
         expect_no_offenses(<<~RUBY)