Merge pull request #1159 from samrjenkins/fix-has-many-or-has-one-dependent-false-positive

[Fix #1158] Rails/HasManyOrHasOneDependent reports false positive when has_many or has_one called on explicit receiver

Author: koic

changelog/fix_has_many_or_has_one_dependent_false_positive.md

@@ -0,0 +1 @@
+* [#1158](https://github.com/rubocop/rubocop-rails/issues/1158): `Rails/HasManyOrHasOneDependent` does not add offence when has_many or has_one is called on an explicit receiver. ([@samrjenkins][])

lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb

@@ -60,7 +60,7 @@ class HasManyOrHasOneDependent < Base
           (block
             (send nil? :with_options
               (hash $...))
-            (args) ...)
+            (args _?) ...)
         PATTERN
 
         def_node_matcher :association_extension_block?, <<~PATTERN

spec/rubocop/cop/rails/has_many_or_has_one_dependent_spec.rb

@@ -92,6 +92,16 @@ class Person < ApplicationRecord
           end
         RUBY
       end
+
+      it 'does not register an offense when has_one called on explicit receiver' do
+        expect_no_offenses(<<~RUBY)
+          class Person < ApplicationRecord
+            with_options dependent: :destroy do |model|
+              model.has_one :foo
+            end
+          end
+        RUBY
+      end
     end
   end
 
@@ -188,6 +198,16 @@ class Person < ApplicationRecord
         RUBY
       end
 
+      it 'does not register an offense when has_many called on explicit receiver' do
+        expect_no_offenses(<<~RUBY)
+          class Person < ApplicationRecord
+            with_options dependent: :destroy do |model|
+              model.has_many :foo
+            end
+          end
+        RUBY
+      end
+
       it "doesn't register an offense for `with_options dependent: :destroy` and for using association extension" do
         expect_no_offenses(<<~RUBY)
           class Person < ApplicationRecord