Support conditions specific to the validator

validates can take a hash of options specific to one validator

Author: etiennebarrie

lib/rubocop/cop/rails/unique_validation_without_index.rb

@@ -139,6 +139,15 @@ def condition_part?(node)
           pairs = node.arguments.last
           return unless pairs.hash_type?
 
+          return true if condition_hash_part?(pairs)
+
+          uniqueness_node = uniqueness_part(node)
+          return unless uniqueness_node&.hash_type?
+
+          condition_hash_part?(uniqueness_node)
+        end
+
+        def condition_hash_part?(pairs)
           pairs.each_pair.any? do |pair|
             key = pair.key
             next unless key.sym_type?

spec/rubocop/cop/rails/unique_validation_without_index_spec.rb

@@ -327,7 +327,7 @@ class Article
         end
       end
 
-      context 'with an if condition on the validation' do
+      context 'without the proper index' do
         let(:schema) { <<~RUBY }
           ActiveRecord::Schema.define(version: 2020_02_02_075409) do
             create_table "articles", force: :cascade do |t|
@@ -336,30 +336,38 @@ class Article
           end
         RUBY
 
-        it 'does not register an offense' do
+        it 'does not register an offense with an if condition on validates' do
           expect_no_offenses(<<~RUBY)
             class Article
               belongs_to :user
               validates :user, uniqueness: true, if: -> { false }
             end
           RUBY
         end
-      end
 
-      context 'with an unless condition on the validation' do
-        let(:schema) { <<~RUBY }
-          ActiveRecord::Schema.define(version: 2020_02_02_075409) do
-            create_table "articles", force: :cascade do |t|
-              t.bigint "user_id", null: false
+        it 'does not register an offense with an unless condition on validates' do
+          expect_no_offenses(<<~RUBY)
+            class Article
+              belongs_to :user
+              validates :user, uniqueness: true, unless: -> { true }
             end
-          end
-        RUBY
+          RUBY
+        end
 
-        it 'does not register an offense' do
+        it 'does not register an offense with an if condition on the specific validator' do
           expect_no_offenses(<<~RUBY)
             class Article
               belongs_to :user
-              validates :user, uniqueness: true, unless: -> { true }
+              validates :user, uniqueness: { if: -> { false } }
+            end
+          RUBY
+        end
+
+        it 'does not register an offense with an unless condition on the specific validator' do
+          expect_no_offenses(<<~RUBY)
+            class Article
+              belongs_to :user
+              validates :user, uniqueness: { unless: -> { false } }
             end
           RUBY
         end