Merge pull request #882 from etiennebarrie/uniqueness-with-conditions

Fix false positive in UniquenessValidator with `conditions`

Author: koic

changelog/fix_support_conditions_option_of.md

@@ -0,0 +1 @@
+* [#882](https://github.com/rubocop/rubocop-rails/pull/882): Fix false positive for `Rails/UniqueValidationWithoutIndex` with :conditions option. ([@etiennebarrie][])

lib/rubocop/cop/rails/unique_validation_without_index.rb

@@ -139,11 +139,20 @@ def condition_part?(node)
           pairs = node.arguments.last
           return unless pairs.hash_type?
 
+          return true if condition_hash_part?(pairs, keys: %i[if unless])
+
+          uniqueness_node = uniqueness_part(node)
+          return unless uniqueness_node&.hash_type?
+
+          condition_hash_part?(uniqueness_node, keys: %i[if unless conditions])
+        end
+
+        def condition_hash_part?(pairs, keys:)
           pairs.each_pair.any? do |pair|
             key = pair.key
             next unless key.sym_type?
 
-            key.value == :if || key.value == :unless
+            keys.include?(key.value)
           end
         end
 

spec/rubocop/cop/rails/unique_validation_without_index_spec.rb

@@ -327,7 +327,7 @@ class Article
         end
       end
 
-      context 'with an if condition on the validation' do
+      context 'without the proper index' do
         let(:schema) { <<~RUBY }
           ActiveRecord::Schema.define(version: 2020_02_02_075409) do
             create_table "articles", force: :cascade do |t|
@@ -336,30 +336,48 @@ class Article
           end
         RUBY
 
-        it 'does not register an offense' do
+        it 'does not register an offense with an if condition on validates' do
           expect_no_offenses(<<~RUBY)
             class Article
               belongs_to :user
               validates :user, uniqueness: true, if: -> { false }
             end
           RUBY
         end
-      end
 
-      context 'with an unless condition on the validation' do
-        let(:schema) { <<~RUBY }
-          ActiveRecord::Schema.define(version: 2020_02_02_075409) do
-            create_table "articles", force: :cascade do |t|
-              t.bigint "user_id", null: false
+        it 'does not register an offense with an unless condition on validates' do
+          expect_no_offenses(<<~RUBY)
+            class Article
+              belongs_to :user
+              validates :user, uniqueness: true, unless: -> { true }
             end
-          end
-        RUBY
+          RUBY
+        end
 
-        it 'does not register an offense' do
+        it 'does not register an offense with an if condition on the specific validator' do
           expect_no_offenses(<<~RUBY)
             class Article
               belongs_to :user
-              validates :user, uniqueness: true, unless: -> { true }
+              validates :user, uniqueness: { if: -> { false } }
+            end
+          RUBY
+        end
+
+        it 'does not register an offense with an unless condition on the specific validator' do
+          expect_no_offenses(<<~RUBY)
+            class Article
+              belongs_to :user
+              validates :user, uniqueness: { unless: -> { false } }
+            end
+          RUBY
+        end
+
+        it 'does not register an offense with a conditions option on the specific validator' do
+          expect_no_offenses(<<~RUBY)
+            class Article
+              belongs_to :user
+              enum :status, [:draft, :published]
+              validates :user, uniqueness: { conditions: -> { published } }
             end
           RUBY
         end