Merge pull request #1287 from koic/mark_rails_skips_model_validations_as_unsafe

koic · web-flow · commit afcf639a815b · 2024-05-29T01:51:06.000+09:00
[Fix #1286] Mark `Rails/SkipsModelValidations` as unsafe
diff --git a/changelog/change_mark_rails_skips_model_validations_as_unsafe.md b/changelog/change_mark_rails_skips_model_validations_as_unsafe.md
@@ -0,0 +1 @@
+* [#1286](https://github.com/rubocop/rubocop-rails/issues/1286): Mark `Rails/SkipsModelValidations` as unsafe. ([@koic][])
diff --git a/config/default.yml b/config/default.yml
@@ -1018,8 +1018,9 @@ Rails/SkipsModelValidations:
                  See reference for more information.
   Reference: 'https://guides.rubyonrails.org/active_record_validations.html#skipping-validations'
   Enabled: true
+  Safe: false
   VersionAdded: '0.47'
-  VersionChanged: '2.7'
+  VersionChanged: '<<next>>'
   ForbiddenMethods:
     - decrement!
     - decrement_counter
diff --git a/lib/rubocop/cop/rails/skips_model_validations.rb b/lib/rubocop/cop/rails/skips_model_validations.rb
@@ -9,6 +9,9 @@ module Rails
       #
       # Methods may be ignored from this rule by configuring a `AllowedMethods`.
       #
+      # @safety
+      #   This cop is unsafe if the receiver object is not an Active Record object.
+      #
       # @example
       #   # bad
       #   Article.first.decrement!(:view_count)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+* [#1286](https://github.com/rubocop/rubocop-rails/issues/1286): Mark `Rails/SkipsModelValidations` as unsafe. ([@koic][])
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,9 @@ module Rails`
`9`	`9`	`#`
`10`	`10`	# Methods may be ignored from this rule by configuring a `AllowedMethods`.
`11`	`11`	`#`
	`12`	`+ # @safety`
	`13`	`+ # This cop is unsafe if the receiver object is not an Active Record object.`
	`14`	`+ #`
`12`	`15`	`# @example`
`13`	`16`	`# # bad`
`14`	`17`	`# Article.first.decrement!(:view_count)`