Merge pull request #1114 from masato-bkn/fix/rails_redundant_active_record_all_when_all_has_arguments

[Fix: #1110] Fix false positive for `Rails/RedundantActiveRecordAllMethod` when `all` has any parameters

Author: koic

changelog/fix_false_positive_for_rails_redundant_active_record_all_method_when_all_has_any_parameters.md

@@ -0,0 +1 @@
+* [#1110](https://github.com/rubocop/rubocop-rails/issues/1110): Fix false positive for `Rails/RedundantActiveRecordAllMethod` when `all` has any parameters. ([@masato-bkn][])

lib/rubocop/cop/rails/redundant_active_record_all_method.rb

@@ -127,7 +127,7 @@ class RedundantActiveRecordAllMethod < Base
         ].to_set.freeze
 
         def_node_matcher :followed_by_query_method?, <<~PATTERN
-          (send (send _ :all ...) QUERYING_METHODS ...)
+          (send (send _ :all) QUERYING_METHODS ...)
         PATTERN
 
         def on_send(node)

spec/rubocop/cop/rails/redundant_active_record_all_method_spec.rb

@@ -260,6 +260,26 @@
         RUBY
       end
     end
+
+    context 'when `all` has any parameters, it indicates that it is not an Active Record `all`' do
+      it 'does not register an offense when no method follows `all`' do
+        expect_no_offenses(<<~RUBY)
+          page.all(:parameter)
+        RUBY
+      end
+
+      it 'does not register an offense when method follows `all`' do
+        expect_no_offenses(<<~RUBY)
+          page.all(:parameter).do_something
+        RUBY
+      end
+
+      it 'does not register an offense when method from `ActiveRecord::Querying::QUERYING_METHODS` follows `all`' do
+        expect_no_offenses(<<~RUBY)
+          page.all(:parameter).select(some_filter)
+        RUBY
+      end
+    end
   end
 
   context 'with no receiver' do