Merge pull request #899 from koic/fix_a_false_positive_for_rails_active_record_aliases

[Fix #898] Fix a false positive for `Rails/ActiveRecordAliases`

Author: koic

changelog/fix_a_false_positive_for_rails_active_record_aliases.md

@@ -0,0 +1 @@
+* [#898](https://github.com/rubocop/rubocop-rails/issues/898): Fix a false positive for `Rails/ActiveRecordAliases` when arguments of `update_attributes` is empty. ([@koic][])

lib/rubocop/cop/rails/active_record_aliases.rb

@@ -26,6 +26,8 @@ class ActiveRecordAliases < Base
         RESTRICT_ON_SEND = ALIASES.keys.freeze
 
         def on_send(node)
+          return if node.arguments.empty?
+
           method_name = node.method_name
           alias_method = ALIASES[method_name]
 

spec/rubocop/cop/rails/active_record_aliases_spec.rb

@@ -25,6 +25,14 @@
         RUBY
       end
     end
+
+    context 'when arguments of `update_attributes` is empty' do
+      it 'does not register an offense' do
+        expect_no_offenses(<<~RUBY)
+          user.update(update_attributes)
+        RUBY
+      end
+    end
   end
 
   describe '#update_attributes!' do