Merge pull request #1229 from markokajzer/master

do not allow EnvironmentVariableAccess in initializers

Author: koic

changelog/change_fix_do_not_allow.md

@@ -0,0 +1 @@
+* [#1229](https://github.com/rubocop/rubocop-rails/pull/1229): Make `Rails/EnvironmentVariableAccess` aware of initializers. ([@markokajzer][])

config/default.yml

@@ -445,9 +445,10 @@ Rails/EnvironmentVariableAccess:
   # TODO: Set to `pending` status in RuboCop Rails 2 series when migration doc will be written.
   Enabled: false
   VersionAdded: '2.10'
-  VersionChanged: '2.11'
+  VersionChanged: '<<next>>'
   Include:
     - app/**/*.rb
+    - config/initializers/**/*.rb
     - lib/**/*.rb
   Exclude:
     - lib/**/*.rake

docs/modules/ROOT/pages/cops_rails.adoc

@@ -2068,7 +2068,7 @@ ENV["FOO"] = "bar"
 | Name | Default value | Configurable values
 
 | Include
-| `+app/**/*.rb+`, `+lib/**/*.rb+`
+| `+app/**/*.rb+`, `+config/initializers/**/*.rb+`, `+lib/**/*.rb+`
 | Array
 
 | Exclude

spec/rubocop/cop/rails/environment_variable_access_spec.rb

@@ -28,6 +28,23 @@
         Foo::ENV.fetch("BAR")
       RUBY
     end
+
+    it 'registers an offense when reading from an `ENV` key in the config/initializers folder' do
+      file_path = 'config/initializers/foo.rb'
+
+      expect_offense(<<~RUBY, file_path)
+        ACCESS_TOKEN = ENV["ACCESS_TOKEN"]
+                       ^^^ Do not read from `ENV` directly post initialization.
+      RUBY
+    end
+
+    it 'does not register an offense when reading from an `ENV` key in the config folder' do
+      file_path = '/config/foo.rb'
+
+      expect_no_offenses(<<~RUBY, file_path)
+        ACCESS_TOKEN = ENV["ACCESS_TOKEN"]
+      RUBY
+    end
   end
 
   context 'when allowing reads' do