Skip to content

Commit 836ff28

Browse files
committed
Cut 2.17.4
1 parent 3032b74 commit 836ff28

File tree

5 files changed

+44
-2
lines changed

5 files changed

+44
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
## master (unreleased)
44

5+
## 2.17.4 (2022-12-25)
6+
57
### Bug fixes
68

79
* [#870](https://github.com/rubocop/rubocop-rails/issues/870): Fix an error for `Rails/RootPathnameMethods` when using `Rails.env` argument within `Dir.glob`. ([@koic][])

docs/antora.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ name: rubocop-rails
22
title: RuboCop Rails
33
# We always provide version without patch here (e.g. 1.1),
44
# as patch versions should not appear in the docs.
5-
version: ~
5+
version: '2.17'
66
nav:
77
- modules/ROOT/nav.adoc

docs/modules/ROOT/pages/cops_rails.adoc

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -846,6 +846,11 @@ class Post < ApplicationRecord
846846
end
847847
----
848848

849+
=== References
850+
851+
* https://guides.rubyonrails.org/5_0_release_notes.html
852+
* https://github.com/rails/rails/pull/18937
853+
849854
== Rails/Blank
850855

851856
|===
@@ -1039,6 +1044,11 @@ end
10391044
| Array
10401045
|===
10411046

1047+
=== References
1048+
1049+
* https://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-change_table
1050+
* https://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/Table.html
1051+
10421052
== Rails/CompactBlank
10431053

10441054
|===
@@ -2844,6 +2854,7 @@ end
28442854

28452855
=== References
28462856

2857+
* https://api.rubyonrails.org/classes/AbstractController/Callbacks/ClassMethods.html#method-i-_normalize_callback_options
28472858
* https://api.rubyonrails.org/classes/AbstractController/Callbacks/ClassMethods.html#method-i-_normalize_callback_options
28482859

28492860
== Rails/IndexBy
@@ -3126,6 +3137,11 @@ end
31263137
| Array
31273138
|===
31283139

3140+
=== References
3141+
3142+
* https://guides.rubyonrails.org/association_basics.html#bi-directional-associations
3143+
* https://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#module-ActiveRecord::Associations::ClassMethods-label-Setting+Inverses
3144+
31293145
== Rails/LexicallyScopedActionFilter
31303146

31313147
|===
@@ -4921,6 +4937,7 @@ end
49214937

49224938
* https://rails.rubystyle.guide#reversible-migration
49234939
* https://api.rubyonrails.org/classes/ActiveRecord/Migration/CommandRecorder.html
4940+
* https://api.rubyonrails.org/classes/ActiveRecord/Migration/CommandRecorder.html
49244941

49254942
== Rails/ReversibleMigrationMethodDefinition
49264943

@@ -6023,6 +6040,10 @@ ApplicationRecord.transaction do
60236040
end
60246041
----
60256042

6043+
=== References
6044+
6045+
* https://github.com/rails/rails/commit/15aa4200e083
6046+
60266047
== Rails/UniqBeforePluck
60276048

60286049
|===

lib/rubocop/rails/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ module RuboCop
44
module Rails
55
# This module holds the RuboCop Rails version information.
66
module Version
7-
STRING = '2.17.3'
7+
STRING = '2.17.4'
88

99
def self.document_version
1010
STRING.match('\d+\.\d+').to_s

relnotes/v2.17.4.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
### Bug fixes
2+
3+
* [#870](https://github.com/rubocop/rubocop-rails/issues/870): Fix an error for `Rails/RootPathnameMethods` when using `Rails.env` argument within `Dir.glob`. ([@koic][])
4+
* [#881](https://github.com/rubocop/rubocop-rails/pull/881): Fix a false positive for `Rails/ActionControllerFlashBeforeRender` when using `flash` in multiline `rescue` branch before `redirect_to`. ([@gurix][])
5+
* [#871](https://github.com/rubocop/rubocop-rails/pull/871): Fix a false positive for `Rails/WhereMissing` when `left_joins(:foo)` and `where(foos: {id: nil})` separated by `or`, `and`. ([@ydah][])
6+
* [#875](https://github.com/rubocop/rubocop-rails/pull/875): Make `Rails/RootPathnameMethods` aware of enforced style of `Style/StringLiterals`. ([@koic][])
7+
* [#882](https://github.com/rubocop/rubocop-rails/pull/882): Fix false positive for `Rails/UniqueValidationWithoutIndex` with :conditions option. ([@etiennebarrie][])
8+
* [#821](https://github.com/rubocop/rubocop-rails/issues/821): Enhance `Rails/TimeZone` to accept methods with the `:in` timezone option. ([@fatkodima][])
9+
10+
### Changes
11+
12+
* [#880](https://github.com/rubocop/rubocop-rails/pull/880): Add Rails/I18nLocaleTexts match for redirect_back. ([@bensheldon][])
13+
14+
[@koic]: https://github.com/koic
15+
[@gurix]: https://github.com/gurix
16+
[@ydah]: https://github.com/ydah
17+
[@etiennebarrie]: https://github.com/etiennebarrie
18+
[@fatkodima]: https://github.com/fatkodima
19+
[@bensheldon]: https://github.com/bensheldon

0 commit comments

Comments
 (0)