Merge pull request #1361 from masato-bkn/fix-rails-compact-blank

Fix `Rails/CompactBlank` to avoid reporting offense for `filter` in Ruby versions below 2.6

Author: koic

lib/rubocop/cop/rails/compact_blank.rb

@@ -80,6 +80,7 @@ class CompactBlank < Base
         PATTERN
 
         def on_send(node)
+          return if target_ruby_version < 2.6 && node.method?(:filter)
           return unless bad_method?(node)
 
           range = offense_range(node)

spec/rubocop/cop/rails/compact_blank_spec.rb

@@ -257,6 +257,27 @@ def foo(arg)
         collection.filter { |e| e.blank? }
       RUBY
     end
+
+    context 'target_ruby_version >= 2.6', :ruby26 do
+      it 'registers and corrects an offense when using `filter { |e| e.present? }`' do
+        expect_offense(<<~RUBY)
+          collection.filter { |e| e.present? }
+                     ^^^^^^^^^^^^^^^^^^^^^^^^^ Use `compact_blank` instead.
+        RUBY
+
+        expect_correction(<<~RUBY)
+          collection.compact_blank
+        RUBY
+      end
+    end
+
+    context 'target_ruby_version < 2.6', :ruby25, unsupported_on: :prism do
+      it 'does not register an offense when using `filter { |e| e.present? }`' do
+        expect_no_offenses(<<~RUBY)
+          collection.filter { |e| e.present? }
+        RUBY
+      end
+    end
   end
 
   context 'Rails <= 6.0', :rails60 do