Merge pull request #867 from r7kamura/feature/index-method

Fix autocorrection bug when `::Hash` is used on `Rails/IndexBy` and `Rails/IndexWith`

Author: koic

changelog/fix_autocorrection_bug_when_hash_is_used_on.md

@@ -0,0 +1 @@
+* [#867](https://github.com/rubocop/rubocop-rails/pull/867): Fix autocorrection bug when `::Hash` is used on `Rails/IndexBy` and `Rails/IndexWith`. ([@r7kamura][])

lib/rubocop/cop/mixin/index_method.rb

@@ -134,7 +134,7 @@ def self.from_map_to_h(node, match)
         end
 
         def self.from_hash_brackets_map(node, match)
-          new(match, node.children.last, 'Hash['.length, ']'.length)
+          new(match, node.children.last, "#{node.receiver.source}[".length, ']'.length)
         end
 
         def strip_prefix_and_suffix(node, corrector)

spec/rubocop/cop/rails/index_by_spec.rb

@@ -145,6 +145,17 @@
     RUBY
   end
 
+  it 'registers an offense for `::Hash[map { ... }]`' do
+    expect_offense(<<~RUBY)
+      ::Hash[x.map { |el| [el.to_sym, el] }]
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `index_by` over `Hash[map { ... }]`.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      x.index_by { |el| el.to_sym }
+    RUBY
+  end
+
   context 'when using Ruby 2.6 or newer', :ruby26 do
     it 'registers an offense for `to_h { ... }`' do
       expect_offense(<<~RUBY)

spec/rubocop/cop/rails/index_with_spec.rb

@@ -118,6 +118,17 @@
       RUBY
     end
 
+    it 'registers an offense for `::Hash[map { ... }]`' do
+      expect_offense(<<~RUBY)
+        ::Hash[x.map { |el| [el, el.to_sym] }]
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `index_with` over `Hash[map { ... }]`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        x.index_with { |el| el.to_sym }
+      RUBY
+    end
+
     context 'when using Ruby 2.6 or newer', :ruby26 do
       it 'registers an offense for `to_h { ... }`' do
         expect_offense(<<~RUBY)