File tree Expand file tree Collapse file tree 1 file changed +4
-5
lines changed Expand file tree Collapse file tree 1 file changed +4
-5
lines changed Original file line number Diff line number Diff line change @@ -1061,9 +1061,9 @@ Use ranges instead of defining comparative conditions using a template for scala
1061
1061
[source,ruby]
1062
1062
----
1063
1063
# bad
1064
- User.where("created_at > ?", 30.days.ago).where("created_at < ?", 7.days.ago)
1065
- User.where("created_at > ? AND created_at < ?", 30.days.ago, 7.days.ago)
1066
- User.where("created_at > :start AND created_at < end", start: 30.days.ago, end: 7.days.ago)
1064
+ User.where("created_at >= ?", 30.days.ago).where("created_at <= ?", 7.days.ago)
1065
+ User.where("created_at >= ? AND created_at <= ?", 30.days.ago, 7.days.ago)
1066
+ User.where("created_at >= :start AND created_at <= : end", start: 30.days.ago, end: 7.days.ago)
1067
1067
1068
1068
# good
1069
1069
User.where(created_at: 30.days.ago..7.days.ago)
@@ -1080,8 +1080,7 @@ User.where(created_at: 7.days.ago...) # also produces >=
1080
1080
User.where(created_at: ..7.days.ago) # inclusive: produces <=
1081
1081
User.where(created_at: ...7.days.ago) # exclusive: produces <
1082
1082
1083
- # okish - there is no range syntax that would denote inclusion on one end and
1084
- # exclusion on another.
1083
+ # okish - there is no range syntax that would denote exclusion at the beginning of the range
1085
1084
Customer.where("purchases_count > :min AND purchases_count <= :max", min: 0, max: 5)
1086
1085
----
1087
1086
You can’t perform that action at this time.
0 commit comments