Skip to content

Refactoring Tests are testing the whole refactoring system #4528

Open
@Vogel612

Description

@Vogel612

This showed up when I was working #4072.

Most of the "unit tests" related to refactorings had tests for the different component parts of the refactoring pushed into a single file.

That means tests for Presenters, Models and Refactorings all were inside the same TestFixture, posing as a "Unit Test" while actually relating to a whole system.
These Tests should be moved into separate classes. Common helper methods should also get their own class.

This necessitates creating separate folders for the different refactorings, which is something we should be doing anyways, if only to map the structure that the production code has.

Metadata

Metadata

Assignees

No one assigned

    Labels

    development-issueIssues encountered while developing RD, not in RD itselfdifficulty-01-ducklingIssue where no particularly involved knowledge of the internal API is needed.enhancementFeature requests, or enhancements to existing features. Ideas. Anything within the project's scope.feature-refactoringsrubberduck-test-projecttechnical-debtThis makes development harder or is leftover from a PullRequest. Needs to be adressed at some point.up-for-grabsUse this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions