Skip to content

Commit ff1c5f6

Browse files
committed
Only report Let or Set in WriteOnlyPropertyInspection
A test was there, but the assert was wrong.
1 parent 68c9f55 commit ff1c5f6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Rubberduck.CodeAnalysis/Inspections/Concrete/WriteOnlyPropertyInspection.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults(Qualifi
5151
{
5252
var setters = RelevantDeclarationsInModule(module, finder)
5353
.Where(declaration => IsResultDeclaration(declaration, finder))
54-
.GroupBy(declaration => declaration.DeclarationType)
54+
.GroupBy(declaration => declaration.QualifiedName)
5555
.Select(grouping => grouping.First()); // don't get both Let and Set accessors
5656

5757
return setters
@@ -62,8 +62,8 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults(Qualifi
6262
protected override bool IsResultDeclaration(Declaration declaration, DeclarationFinder finder)
6363
{
6464
return (declaration.Accessibility == Accessibility.Implicit
65-
|| declaration.Accessibility == Accessibility.Public
66-
|| declaration.Accessibility == Accessibility.Global)
65+
|| declaration.Accessibility == Accessibility.Public
66+
|| declaration.Accessibility == Accessibility.Global)
6767
&& finder.MatchName(declaration.IdentifierName)
6868
.Where(otherDeclaration => otherDeclaration.QualifiedModuleName.Equals(declaration.QualifiedModuleName))
6969
.All(accessor => accessor.DeclarationType != DeclarationType.PropertyGet);

RubberduckTests/Inspections/WriteOnlyPropertyInspectionTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ End Property
4343
Property Set Foo(value)
4444
End Property";
4545

46-
Assert.AreEqual(2, InspectionResultsForModules(("MyClass", inputCode, ComponentType.ClassModule)).Count());
46+
Assert.AreEqual(1, InspectionResultsForModules(("MyClass", inputCode, ComponentType.ClassModule)).Count());
4747
}
4848

4949
[Test]

0 commit comments

Comments
 (0)