Skip to content

Commit fe3fc7c

Browse files
committed
Disable a handful of noisy and expected warnings
1 parent 7ace924 commit fe3fc7c

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

Rubberduck.Core/Rubberduck.Core.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
<Copyright>Copyright © 2014-2018</Copyright>
99
<ProjectGuid>{A1587EAC-7B54-407E-853F-4C7493D0323E}</ProjectGuid>
1010
<DocumentationFile>bin\Debug\Rubberduck.Core.xml</DocumentationFile>
11-
<NoWarn>1591</NoWarn>
11+
<!-- Disable "Missing XML documentation" warning (CS1591) -->
12+
<DisabledWarnings>$(DisabledWarnings);1591</DisabledWarnings>
1213
<ApplicationIcon>Ducky.ico</ApplicationIcon>
1314
<!-- Give a fixed version to not blow XAML generated code to smithereens -->
1415
<AssemblyVersion>2.2</AssemblyVersion>

Rubberduck.Main/Rubberduck.Main.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
<Copyright>Copyright © 2014-2018</Copyright>
77
<Description>Rubberduck AddIn</Description>
88
<ProjectGuid>{E8AB5D93-2D0F-423D-BC15-5EE118673E48}</ProjectGuid>
9-
<NoWarn>1591</NoWarn>
9+
<!-- Disable "Missing XML documentation" warning (CS1591) -->
10+
<DisabledWarnings>$(DisabledWarnings);1591</DisabledWarnings>
1011
</PropertyGroup>
1112
<Import Project="..\RubberduckBaseProject.csproj" />
1213

RubberduckBaseProject.csproj

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,21 @@
1414
<RestorePackages>true</RestorePackages>
1515
<!-- do not unify output paths by default -->
1616
<UnifyOutputPath Condition=" '$(UnifyOutputPath)' == ''">false</UnifyOutputPath>
17+
<!-- Ignore MSB4011 warning, rationale above -->
18+
<!-- Ignore VisualStudio whining about the CodeAnalysis assembly changing (IDE1001) -->
19+
<DisabledWarnings>$(DisabledWarnings);4011;1001</DisabledWarnings>
20+
<Version Condition=" '$(Version)' == ''">2.2.0</Version>
1721
</PropertyGroup>
1822

19-
<PropertyGroup Condition=" '$(Version)' == ''">
20-
<Version>2.2.0</Version>
23+
<PropertyGroup Condition=" '$(AssemblyVersion)' == '' ">
2124
<!--
2225
This assembly version specification is considered nonstandard.
23-
As such builds that do not override the assembly version generate a warning.
24-
-->
25-
<AssemblyVersion Condition=" '$(AssemblyVersion)' == '' ">2.2.*</AssemblyVersion>
26+
As such builds that do not override the assembly version generate a warning, which we ignore.
27+
-->
28+
<AssemblyVersion>2.2.*</AssemblyVersion>
29+
<!-- Ignore CSharp compiler warning for nonstandard assembly version (CS7035) -->
30+
<!-- Ignore Linker warning for nonstandard assembly version (AL1053) -->
31+
<DisabledWarnings>$(DisabledWarnings);7035;1053</DisabledWarnings>
2632
<!-- Wildcards are not deterministic, ensure build passes when setting wildcard versions -->
2733
<Deterministic>False</Deterministic>
2834
</PropertyGroup>

0 commit comments

Comments
 (0)