added CheckVersion setting; *actually* closes #1785

Author: retailcoder

RetailCoder.VBE/App.cs

@@ -13,6 +13,7 @@
 using System.Globalization;
 using System.Linq;
 using System.Windows.Forms;
+using Rubberduck.UI.Command;
 using Rubberduck.UI.Command.MenuItems.CommandBars;
 using Rubberduck.VBEditor.SafeComWrappers.Abstract;
 using Rubberduck.VersionCheck;
@@ -30,6 +31,7 @@ public sealed class App : IDisposable
         private readonly RubberduckCommandBar _stateBar;
         private readonly IRubberduckHooks _hooks;
         private readonly IVersionCheck _version;
+        private readonly CommandBase _checkVersionCommand;
 
         private static readonly Logger Logger = LogManager.GetCurrentClassLogger();
 
@@ -42,7 +44,8 @@ public App(IVBE vbe,
             IAppMenu appMenus,
             RubberduckCommandBar stateBar,
             IRubberduckHooks hooks,
-            IVersionCheck version)
+            IVersionCheck version,
+            CommandBase checkVersionCommand)
         {
             _vbe = vbe;
             _messageBox = messageBox;
@@ -53,6 +56,7 @@ public App(IVBE vbe,
             _stateBar = stateBar;
             _hooks = hooks;
             _version = version;
+            _checkVersionCommand = checkVersionCommand;
 
             _hooks.MessageReceived += _hooks_MessageReceived;
             _configService.SettingsChanged += _configService_SettingsChanged;
@@ -162,6 +166,11 @@ public void Startup()
             _stateBar.SetStatusLabelCaption(ParserState.Pending);
             _stateBar.EvaluateCanExecute(_parser.State);
             UpdateLoggingLevel();
+
+            if (_config.UserSettings.GeneralSettings.CheckVersion)
+            {
+                _checkVersionCommand.Execute(null);
+            }
         }
 
         public void Shutdown()

RetailCoder.VBE/Root/RubberduckModule.cs

@@ -70,6 +70,7 @@ public override void Load()
             Bind<TestExplorerModel>().ToSelf().InSingletonScope();
             Bind<IOperatingSystem>().To<WindowsOperatingSystem>().InSingletonScope();
 
+            Bind<CommandBase>().To<VersionCheckCommand>().WhenInjectedExactlyInto<App>();
             BindCodeInspectionTypes();
 
             var assemblies = new[]

RetailCoder.VBE/Rubberduck.csproj

@@ -232,6 +232,10 @@
     <Reference Include="extensibility, Version=7.0.3300.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
       <EmbedInteropTypes>True</EmbedInteropTypes>
     </Reference>
+    <Reference Include="HtmlAgilityPack, Version=1.4.9.5, Culture=neutral, PublicKeyToken=bd319b19eaf3b43a, processorArchitecture=MSIL">
+      <HintPath>..\packages\HtmlAgilityPack.1.4.9.5\lib\Net45\HtmlAgilityPack.dll</HintPath>
+      <Private>True</Private>
+    </Reference>
     <Reference Include="ICSharpCode.AvalonEdit">
       <HintPath>..\packages\AvalonEdit.5.0.3\lib\Net40\ICSharpCode.AvalonEdit.dll</HintPath>
     </Reference>

RetailCoder.VBE/Settings/GeneralSettings.cs

@@ -9,6 +9,7 @@ public interface IGeneralSettings
     {
         DisplayLanguageSetting Language { get; set; }
         bool ShowSplash { get; set; }
+        bool CheckVersion { get; set; }
         bool SmartIndenterPrompted { get; set; }
         bool AutoSaveEnabled { get; set; }
         int AutoSavePeriod { get; set; }
@@ -21,6 +22,7 @@ public class GeneralSettings : IGeneralSettings, IEquatable<GeneralSettings>
     {
         public DisplayLanguageSetting Language { get; set; }
         public bool ShowSplash { get; set; }
+        public bool CheckVersion { get; set; }
         public bool SmartIndenterPrompted { get; set; }
         public bool AutoSaveEnabled { get; set; }
         public int AutoSavePeriod { get; set; }
@@ -51,6 +53,7 @@ public GeneralSettings()
         {
             Language = new DisplayLanguageSetting("en-US");
             ShowSplash = true;
+            CheckVersion = true;
             SmartIndenterPrompted = false;
             AutoSaveEnabled = false;
             AutoSavePeriod = 10;
@@ -63,6 +66,7 @@ public bool Equals(GeneralSettings other)
             return other != null &&
                    Language.Equals(other.Language) &&
                    ShowSplash == other.ShowSplash &&
+                   CheckVersion == other.CheckVersion &&
                    SmartIndenterPrompted == other.SmartIndenterPrompted &&
                    AutoSaveEnabled == other.AutoSaveEnabled &&
                    AutoSavePeriod == other.AutoSavePeriod &&

RetailCoder.VBE/UI/Command/VersionCheckCommand.cs

@@ -37,17 +37,18 @@ public VersionCheckCommand(IVersionCheck versionCheck, IMessageBox prompt, IExte
             _process = process;
         }
 
-        protected override void ExecuteImpl(object parameter)
+        protected override async void ExecuteImpl(object parameter)
         {
-            _versionCheck.GetLatestVersionAsync().ContinueWith(Execute);
-        }
-
-        private void Execute(Version latestVersion)
-        {
-            if (_versionCheck.CurrentVersion < latestVersion)
-            {
-                PromptAndBrowse(latestVersion);
-            }
+            Logger.Info("Executing version check.");
+            await _versionCheck
+                .GetLatestVersionAsync()
+                .ContinueWith(t =>
+                {
+                    if (_versionCheck.CurrentVersion != t.Result)
+                    {
+                        PromptAndBrowse(t.Result);
+                    }
+                });
         }
 
         private void PromptAndBrowse(Version latestVersion)

RetailCoder.VBE/UI/RubberduckUI.Designer.cs

@@ -1866,6 +1866,9 @@ End Sub</value>
   <data name="SettingsCaption_ImportSettings" xml:space="preserve">
     <value>Import</value>
   </data>
+  <data name="GeneralSettings_CheckVersion" xml:space="preserve">
+    <value>Vérifier si une nouvelle version est diponible au démarrage</value>
+  </data>
   <data name="VersionCheck_NewVersionAvailable" xml:space="preserve">
     <value>La version {0} de Rubberduck est maintenant disponible! Souhaitez-vous consulter les notes de mise à jour maintenant?</value>
   </data>

RetailCoder.VBE/UI/RubberduckUI.fr.resx

@@ -1916,4 +1916,7 @@ Would you like to import them to Rubberduck?</value>
   <data name="VersionCheck_NewVersionAvailable" xml:space="preserve">
     <value>Rubberduck version {0} is now available! Would you like to review the release notes now?</value>
   </data>
+  <data name="GeneralSettings_CheckVersion" xml:space="preserve">
+    <value>Check if a newer version is available at startup</value>
+  </data>
 </root>

RetailCoder.VBE/UI/RubberduckUI.resx

@@ -119,6 +119,9 @@
                     <CheckBox Margin="5,0,0,5" Content="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=GeneralSettings_ShowSplash}"
                               IsChecked="{Binding ShowSplashAtStartup}" />
 
+                    <CheckBox Margin="5,0,0,5" Content="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=GeneralSettings_CheckVersion}"
+                              IsChecked="{Binding CheckVersionAtStartup}" />
+
                     <Label Content="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=GeneralSettings_AutoSaveLabel}" FontWeight="SemiBold" />
                     <StackPanel Orientation="Horizontal">
                         <CheckBox Name="AutoSaveButton"

RetailCoder.VBE/UI/Settings/GeneralSettings.xaml

@@ -96,6 +96,20 @@ public bool ShowSplashAtStartup
             }
         }
 
+        private bool _checkVersionAtStartup;
+        public bool CheckVersionAtStartup
+        {
+            get { return _checkVersionAtStartup; }
+            set
+            {
+                if (_checkVersionAtStartup != value)
+                {
+                    _checkVersionAtStartup = value;
+                    OnPropertyChanged();
+                }
+            }
+        }
+
         private int _autoSavePeriod;
         public int AutoSavePeriod
         {
@@ -167,6 +181,7 @@ private Rubberduck.Settings.GeneralSettings GetCurrentGeneralSettings()
             {
                 Language = SelectedLanguage,
                 ShowSplash = ShowSplashAtStartup,
+                CheckVersion = CheckVersionAtStartup,
                 SmartIndenterPrompted = _indenterPrompted,
                 AutoSaveEnabled = AutoSaveEnabled,
                 AutoSavePeriod = AutoSavePeriod,
@@ -180,6 +195,7 @@ private void TransferSettingsToView(IGeneralSettings general, IHotkeySettings ho
             SelectedLanguage = Languages.First(l => l.Code == general.Language.Code);
             Hotkeys = new ObservableCollection<HotkeySetting>(hottkey.Settings);
             ShowSplashAtStartup = general.ShowSplash;
+            CheckVersionAtStartup = general.CheckVersion;
             _indenterPrompted = general.SmartIndenterPrompted;
             AutoSaveEnabled = general.AutoSaveEnabled;
             AutoSavePeriod = general.AutoSavePeriod;